From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Chris Wright <chrisw@sous-sol.org>
Subject: [patch-mm 20/33] x86_64: remove pit synchronization
Date: Sun, 15 Jul 2007 16:11:01 -0000 [thread overview]
Message-ID: <20070715155541.561244482@inhelltoy.tec.linutronix.de> (raw)
In-Reply-To: <20070715155510.341941668@inhelltoy.tec.linutronix.de>
[-- Attachment #1: x86_64-apic-remove-bogus-pit-synchronization.patch --]
[-- Type: text/plain, Size: 1540 bytes --]
The APIC timer setup code synchronizes the local APIC timer to the
PIT/HPET. This is pointless as the PIT and the local APIC timer
frequency are not correlated and the APIC timer calibration can never
be accurate enough to avoid that the local APIC timer and the PIT/HPET
drift apart.
Simply remove it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86_64/kernel/apic.c | 20 --------------------
1 file changed, 20 deletions(-)
Index: linux-2.6.22-rc6-mm/arch/x86_64/kernel/apic.c
===================================================================
--- linux-2.6.22-rc6-mm.orig/arch/x86_64/kernel/apic.c 2007-07-15 17:39:44.000000000 +0200
+++ linux-2.6.22-rc6-mm/arch/x86_64/kernel/apic.c 2007-07-15 17:48:58.000000000 +0200
@@ -791,26 +791,6 @@ static void setup_APIC_timer(unsigned in
local_irq_save(flags);
- /* wait for irq slice */
- if (hpet_address && hpet_use_timer) {
- int trigger = hpet_readl(HPET_T0_CMP);
- while (hpet_readl(HPET_COUNTER) >= trigger)
- /* do nothing */ ;
- while (hpet_readl(HPET_COUNTER) < trigger)
- /* do nothing */ ;
- } else {
- int c1, c2;
- outb_p(0x00, 0x43);
- c2 = inb_p(0x40);
- c2 |= inb_p(0x40) << 8;
- do {
- c1 = c2;
- outb_p(0x00, 0x43);
- c2 = inb_p(0x40);
- c2 |= inb_p(0x40) << 8;
- } while (c2 - c1 < 300);
- }
-
irqen = ! cpu_isset(smp_processor_id(),
timer_interrupt_broadcast_ipi_mask);
__setup_APIC_LVTT(clocks, 0, irqen);
--
next prev parent reply other threads:[~2007-07-15 16:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 16:10 [patch-mm 00/33] x86_64 clock events conversion - V5 Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 01/33] clockevents: Remove unused inline function Thomas Gleixner
2007-07-17 12:33 ` Andi Kleen
2007-07-17 14:58 ` Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 02/33] clockevents: Allow build w/o run-tine usage for migration purposes Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 03/33] i386: remove pit_interrupt_hook Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 04/33] X86_64: hpet tsc calibration fix broken smi detection logic Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 05/33] x86_64: Untangle asm/hpet.h from asm/timex.h Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 06/33] x86_64: use generic cmos update Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 07/33] x86_64: Use generic xtime init Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 08/33] x86_64: Remove dead code and other janitor work in tsc.c Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 09/33] x86_64: Fix APIC typo Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 10/33] x86_64: fiuxp pt_reqs leftovers Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 11/33] x86_64: share hpet.h with i386 Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 12/33] x86_64: apic.c coding style janitor work Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 13/33] x86_64: time.c white space wreckage cleanup Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 14/33] x86_64: Consolidate tsc calibration Thomas Gleixner
2007-07-17 12:51 ` Andi Kleen
2007-07-17 15:00 ` Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 15/33] i386: prepare sharing the hpet code with x86_64 Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 16/33] i386: hpet add x8664 bits Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 17/33] i386: prepare sharing the PIT code Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 18/33] x86_64: use shared i8253.h Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 19/33] x86_64: prepare apic code for clock events Thomas Gleixner
2007-07-15 16:11 ` Thomas Gleixner [this message]
2007-07-15 16:11 ` [patch-mm 21/33] x86_64: Move apic calibration code around Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 22/33] x86_64: Remove APIC_DIVISOR Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 23/33] x86_64: apic change setup_APIC_timer calling convention Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 24/33] x86_64: remove nested irq disables Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 25/33] x86_64: prepare idle loop for dynamic ticks Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 26/33] x86_64: apic add clock event functions Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 27/33] x86_64: convert to clock events Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 28/33] x86_64: remove now unused code Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 29/33] x86_64: cleanup apic.c after clock events switch Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 30/33] jiffies: remove unused macros Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 31/33] ACPI: remove the now unused ifdef code Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 32/33] i386: Remove the useless #ifdef in i8253.h Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 33/33] i386/x8664: cleanup the shared hpet code Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070715155541.561244482@inhelltoy.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®