From: Oliver Neukum <oliver@neukum.org>
To: linux-usb-devel@lists.sourceforge.net
Cc: Kevin Lloyd <klloyd@sierrawireless.com>,
gregkh@suse.de, linux@sierrawireless.com, torvalds@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] [PATCH 01/02] USB: sierra: Add TRU-Install (c) Support [ATTEMPT 4]
Date: Mon, 16 Jul 2007 13:55:08 +0200 [thread overview]
Message-ID: <200707161355.08548.oliver@neukum.org> (raw)
In-Reply-To: <4696C9EF.9050406@sierrawireless.com>
Am Freitag 13 Juli 2007 schrieb Kevin Lloyd:
> +int sierra_probe(struct usb_interface *iface, const struct usb_device_id *id)
> +{
> + int result;
> + struct usb_device *udev;
> +
> + udev = usb_get_dev(interface_to_usbdev(iface));
> +
> + /* Check if in installer mode */
> + if (id->driver_info == DEVICE_INSTALLER){
> + dev_dbg(&udev->dev, "%s", "FOUND DEVICE(SW)\n");
> + result = sierra_set_ms_mode(udev, SWIMS_SET_MODE_Modem);
> + return result;
As I mentioned, you'd better return -EIO here. You don't want to bind
to the device, as it is not yet a serial device and you want the driver core
to stop trying while it goes away and transforms itself.
Regards
Oliver
next prev parent reply other threads:[~2007-07-16 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 0:40 Kevin Lloyd
2007-07-16 11:55 ` Oliver Neukum [this message]
2007-07-16 16:27 ` [linux-usb-devel] " Kevin Lloyd
2007-07-16 20:49 ` [PATCH 01/02] USB: sierra: Add TRU-Install (c) Support [ATTEMPT 5] Kevin Lloyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707161355.08548.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=gregkh@suse.de \
--cc=klloyd@sierrawireless.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linux@sierrawireless.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®