From: David Miller <davem@davemloft.net>
To: oleg@tv-sign.ru
Cc: torvalds@linux-foundation.org, 76306.1226@compuserve.com,
mingo@elte.hu, roland@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: Q: a bogus set_fs(USER_DS) in setup_frame/setup_rt_frame ?
Date: Tue, 17 Jul 2007 12:36:00 -0700 (PDT) [thread overview]
Message-ID: <20070717.123600.71091634.davem@davemloft.net> (raw)
In-Reply-To: <20070717171535.GA431@tv-sign.ru>
From: Oleg Nesterov <oleg@tv-sign.ru>
Date: Tue, 17 Jul 2007 21:15:35 +0400
> Also, sparc does something strange with do_sigaltstack(). It first copies
> stack_t to the local variable, then sets KERNEL_DS to access it from
> do_sigaltstack().
>
> IOW, what's wrong with the patch below? Why should we ignore errors other
> than -EFAULT?
Nothing wrong with it.
The code is this way because it was simply copied over from
the signal32.c implementation which has to translate around
the 32-bit types into the 64-bit ones the kernel wants.
But since the 64-bit side doesn't need the translations,
it doesn't need to do the funny do_sigaltstack() call sequence
either.
I'll apply your patch, thanks!
prev parent reply other threads:[~2007-07-17 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 15:46 Oleg Nesterov
2007-07-17 16:04 ` [patch] i386: remove unnecessary code Ingo Molnar
2007-07-17 16:05 ` Q: a bogus set_fs(USER_DS) in setup_frame/setup_rt_frame ? Linus Torvalds
2007-07-17 17:15 ` Oleg Nesterov
2007-07-17 19:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717.123600.71091634.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®