From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, devel@openvz.org,
Thomas Gleixner <tglx@linutronix.de>,
stable@kernel.org
Subject: Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
Date: Tue, 17 Jul 2007 14:36:10 +0200 [thread overview]
Message-ID: <20070717123511.GB17657@elte.hu> (raw)
In-Reply-To: <20070717122511.GD25083@localhost.sw.ru>
* Alexey Dobriyan <adobriyan@sw.ru> wrote:
> On every open/close one struct seq_operations leaks.
> Kudos to /proc/slab_allocators.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
ouch ...
Acked-by: Ingo Molnar <mingo@elte.hu>
-stable material too, as far as timer_info/stats goes.
> - .release = seq_release,
> + .release = single_release,
i think seq_release() definitely needs to grow a WARN_ON() if it's being
used on an inode that was opened via single_open(). This bug is so
easily committed, and nothing but a small leak reminds us on it.
Ingo
next prev parent reply other threads:[~2007-07-17 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 12:25 Alexey Dobriyan
2007-07-17 12:36 ` Ingo Molnar [this message]
2007-07-17 12:57 ` [PATCH] Fix leak on /proc/lockdep_stats Alexey Dobriyan
2007-07-18 0:53 ` [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats} Andrew Morton
2007-07-18 1:28 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717123511.GB17657@elte.hu \
--to=mingo@elte.hu \
--cc=adobriyan@sw.ru \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®