From: Sam Ravnborg <sam@ravnborg.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Domen Puncer <domen.puncer@telargo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] introduce __init_exit function annotation
Date: Tue, 17 Jul 2007 17:14:32 +0200 [thread overview]
Message-ID: <20070717151432.GA25939@uranus.ravnborg.org> (raw)
In-Reply-To: <s5htzs3ulpf.wl%tiwai@suse.de>
On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote:
> At Tue, 17 Jul 2007 15:02:30 +0200,
> Sam Ravnborg wrote:
> >
> > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote:
> > > Introduce __init_exit, which is useful ie. for drivers that call
> > > cleanup functions when they fail in __init functions.
> >
> > This is wrong.
> > On arm (just one example of several) the __exit section are discarded
> > at buildtime so any reference from __init to __exit will cause the
> > linker to error out.
>
> Hmm, from what I see, it adds __init to the function. There is no
> reference to __exit.
The cleanup functions are marked __exit in the referenced case.
Sam
next prev parent reply other threads:[~2007-07-17 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 8:02 Domen Puncer
2007-07-17 8:31 ` Adrian Bunk
2007-07-17 8:55 ` Domen Puncer
2007-07-17 13:02 ` Sam Ravnborg
2007-07-17 14:52 ` Takashi Iwai
2007-07-17 15:14 ` Sam Ravnborg [this message]
2007-07-17 15:16 ` Takashi Iwai
2007-07-17 15:32 ` Sam Ravnborg
2007-07-17 15:40 ` Takashi Iwai
2007-07-17 16:48 ` Sam Ravnborg
2007-07-17 17:02 ` Takashi Iwai
2007-07-17 19:44 ` Domen Puncer
2007-07-17 17:48 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717151432.GA25939@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=domen.puncer@telargo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome