From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: Avi Kivity <avi@qumranet.com>, linux-kernel@vger.kernel.org
Subject: a52b1752c07 broke !SMP: error: implicit declaration of function `WARN_ON'
Date: Wed, 18 Jul 2007 01:24:46 +0200 [thread overview]
Message-ID: <20070717232446.GA20140@lala> (raw)
Hello,
kernel/timer.c (and some others as arch/arm/kernel/irq.c) include
<linux/smp.h>, but not <linux/kernel.h>
a52b1752c07 introduces usage of the WARN_ON macro in <linux/smp.h>, but
doesn't pull in <linux/kernel.h>. (<asm/bug.h> is not enough, at least
for arm, because WARN_ON uses printk there.)
The obvious options are:
1) include <linux/kernel.h> in <linux/smp.h>, maybe conditioned by !SMP
2) include <linux/kernel.h> in all includers of <linux/smp.h>
3) remove the WARN_ONs introduced by a52b1752c07.
WARN_ON is used in an inline function that isn't used in every file
including <linux/smp.h>, so maybe updating the compiler might make
the effort for 2) smaller!? (I'm using gcc 3.4.4)
Best regards
Uwe
--
Uwe Kleine-König
$ dc -e "5735816763073014741799356604682P"
next reply other threads:[~2007-07-17 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 23:24 Uwe Kleine-König [this message]
2007-07-17 23:54 ` Al Viro
2007-07-18 4:16 ` [PATCH] UP: smp_call_function_single() must warn on irqs_disabled() Satyam Sharma
2007-07-18 4:49 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070717232446.GA20140@lala \
--to=ukleinek@informatik.uni-freiburg.de \
--cc=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome