From: Al Viro <viro@ftp.linux.org.uk>
To: Ben Dooks <ben@fluff.org>
Cc: David Miller <davem@davemloft.net>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
avi@qumranet.com
Subject: Re: [PATCH] smp_call_function_single() should be a macro on UP
Date: Wed, 18 Jul 2007 01:00:45 +0100 [thread overview]
Message-ID: <20070718000045.GR21668@ftp.linux.org.uk> (raw)
In-Reply-To: <20070717235417.GA18459@fluff.org.uk>
On Wed, Jul 18, 2007 at 12:54:17AM +0100, Ben Dooks wrote:
> This has broken _all_ ARM builds, due to using WARN_ON()
> in this header. Warn on needs <asm/bug.h> and this is
> needs <linux/kernel.h> to make it compile cleanly on ARM
> which is unfortuantely what we where trying to avoid in
> the first place?
>
> This patch fixes the compile on ARM, but moves the
> includes out of the CONFIG_SMP block.
Which "this" are you refering to? Original introduction of inline
or switch to a macro on top of it?
FWIW, with "turn to macro" all arm builds I have here pass fine.
Please, check if current Linus' tree (already with that patch)
works for you; I very much object to pulling more includes in
there, that way lies a lot of breakage.
next prev parent reply other threads:[~2007-07-18 0:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 21:29 Al Viro
2007-07-17 21:40 ` David Miller
2007-07-17 23:54 ` Ben Dooks
2007-07-18 0:00 ` Al Viro [this message]
2007-07-18 0:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718000045.GR21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=avi@qumranet.com \
--cc=ben@fluff.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®