From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932184AbXGRLHB (ORCPT ); Wed, 18 Jul 2007 07:07:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762986AbXGRLGs (ORCPT ); Wed, 18 Jul 2007 07:06:48 -0400 Received: from brick.kernel.dk ([80.160.20.94]:19063 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756526AbXGRLGq (ORCPT ); Wed, 18 Jul 2007 07:06:46 -0400 Date: Wed, 18 Jul 2007 13:06:19 +0200 From: Jens Axboe To: Tejun Heo Cc: Neil Brown , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, David Chinner , Phillip Susi , Stefan Bader , Andreas Dilger Subject: Re: [PATCH] block: factor out bio_check_eod() Message-ID: <20070718110619.GM11657@kernel.dk> References: <18006.38689.818186.221707@notabene.brown> <18010.12472.209452.148229@notabene.brown> <20070530093503.GA15559@kernel.dk> <20070718105655.GB22374@htj.dyndns.org> <20070718105946.GC22374@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070718105946.GC22374@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18 2007, Tejun Heo wrote: > End of device check is done twice in __generic_make_request() and it's > fully inlined each time. Factor out bio_check_eod(). Tejun, yeah I should seperate the cleanups and put them in the upstream branch. Will do so and add your signed-off to both of them. -- Jens Axboe