From: Andrew Morton <akpm@linux-foundation.org>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: LKML <linux-kernel@vger.kernel.org>,
Gustavo de Nardin <gustavodn@mandriva.com.br>
Subject: Re: [PATCH] Include serial_reg.h with userspace headers
Date: Wed, 18 Jul 2007 18:08:29 -0700 [thread overview]
Message-ID: <20070718180829.8f736843.akpm@linux-foundation.org> (raw)
In-Reply-To: <200707150002.39321.herton@mandriva.com.br>
On Sun, 15 Jul 2007 00:02:39 -0300
Herton Ronaldo Krzesinski <herton@mandriva.com.br> wrote:
> As reported by Gustavo de Nardin <gustavodn@mandriva.com.br>, while trying to
> compile xosview (http://xosview.sourceforge.net/) with upstream kernel
> headers being used you get the following errors:
> serialmeter.cc:48:30: error: linux/serial_reg.h: No such file or directory
> serialmeter.cc: In member function 'virtual void
> SerialMeter::checkResources()':
> serialmeter.cc:71: error: 'UART_LSR' was not declared in this scope
> serialmeter.cc:71: error: 'UART_MSR' was not declared in this scope
> ...
>
> I don't know if it's right to provide serial_reg.h with userspace headers, may
> be serial_reg.h isn't included for some reason. But if it's ok, the following
> patch adds serial_reg.h to be installed with user space kernel headers:
>
Well that file is just a pile of "#define name number"s so I guess it's
OK to export it to save someone some typing, and to avoid breaking existing
stuff more than we need to.
prev parent reply other threads:[~2007-07-19 1:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 3:02 Herton Ronaldo Krzesinski
2007-07-19 1:08 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718180829.8f736843.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gustavodn@mandriva.com.br \
--cc=herton@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®