From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764866AbXGSMAp (ORCPT ); Thu, 19 Jul 2007 08:00:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757656AbXGSMAf (ORCPT ); Thu, 19 Jul 2007 08:00:35 -0400 Received: from mtagate8.uk.ibm.com ([195.212.29.141]:53238 "EHLO mtagate8.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757384AbXGSMAe (ORCPT ); Thu, 19 Jul 2007 08:00:34 -0400 Date: Thu, 19 Jul 2007 14:00:38 +0200 From: Cornelia Huck To: Geert Uytterhoeven Cc: Andrew Morton , Andy Whitcroft , Jens Axboe , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, Linux Kernel Development , Linux/PPC Development , Paul Mackerras , Jens Axboe Subject: Re: [patch 1/3] ps3: Disk Storage Driver Message-ID: <20070719140038.606abd44@gondolin.boeblingen.de.ibm.com> In-Reply-To: References: <20070716161539.075822000@pademelon.sonytel.be> <20070716162206.392129000@pademelon.sonytel.be> <20070718163637.3f0e0164.akpm@linux-foundation.org> <20070719112602.5e3cb21a@gondolin.boeblingen.de.ibm.com> Organization: IBM Deutschland Entwicklung GmbH X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.13; i486-pc-linux-gnu) X-Legal: IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?= Herbert Kircher Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?= Registergericht: Amtsgericht Stuttgart, HRB 243294 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Jul 2007 11:36:31 +0200 (CEST), Geert Uytterhoeven wrote: > We have a probe thread that checks for new storage devices and adds them to the > bus with ps3_system_bus_device_register(), which calls device_register(). > > I guess the actual bus probe() routine gets called through the notifier call > chain? That's where I got lost... No, ->probe() is called from device_register() directly. If you just have one probe thread, you should have enough serialization. (Unless you're doing something interesting from the bus_notifier, which is called via the notifier chain before ->probe()...)