From: Michael Halcrow <mhalcrow@us.ibm.com>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
tchicks@us.ibm.com, trevor.highland@gmail.com,
pregan@ic.sunysb.edu, toml@us.ibm.com, sergeh@us.ibm.com,
mike@halcrow.us
Subject: Re: [PATCH 4/8] eCryptfs: Fix Tag 1 parsing code
Date: Thu, 19 Jul 2007 16:53:48 -0500 [thread overview]
Message-ID: <20070719215347.GA14091@halcrow.austin.ibm.com> (raw)
In-Reply-To: <20070719214116.GA4041@filer.fsl.cs.sunysb.edu>
On Thu, Jul 19, 2007 at 05:41:16PM -0400, Josef Sipek wrote:
> On Thu, Jul 19, 2007 at 04:28:01PM -0500, Michael Halcrow wrote:
> > Fix up the Tag 1 parsing code to handle size limits and boundaries
> > more explicitly. Initialize the new auth_tok's flags.
> ...
> > - if (unlikely((*packet_size) + 3 > max_packet_size)) {
> > - ecryptfs_printk(KERN_ERR, "Packet size exceeds max\n");
> > + if (unlikely(max_packet_size < 12)) {
> > + printk(KERN_ERR "Invalid max packet size; must be >=12\n");
>
> Hardcoded 12?
It's not so much a magic number if you preserve the comment
immediately above it.
next prev parent reply other threads:[~2007-07-19 21:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 21:24 [PATCH 0/8] eCryptfs: Support multiple keys per inode Michael Halcrow
2007-07-19 21:25 ` [PATCH 1/8] eCryptfs: Add key list structure; search keyring Michael Halcrow
2007-07-20 13:48 ` Serge E. Hallyn
2007-07-20 22:26 ` Andrew Morton
2007-07-19 21:26 ` [PATCH 2/8] eCryptfs: Use list_for_each_entry_safe() when wiping auth toks Michael Halcrow
2007-07-19 21:27 ` [PATCH 3/8] eCryptfs: kmem_cache objects for multiple keys; init/exit functions Michael Halcrow
2007-07-19 21:28 ` [PATCH 4/8] eCryptfs: Fix Tag 1 parsing code Michael Halcrow
2007-07-19 21:41 ` Josef Sipek
2007-07-19 21:53 ` Michael Halcrow [this message]
2007-07-19 21:28 ` [PATCH 5/8] eCryptfs: Fix Tag 3 " Michael Halcrow
2007-07-19 21:29 ` [PATCH 6/8] eCryptfs: Fix Tag 11 " Michael Halcrow
2007-07-19 21:30 ` [PATCH 7/8] eCryptfs: Fix Tag 11 writing code Michael Halcrow
2007-07-19 21:30 ` [PATCH 8/8] eCryptfs: Update comment and debug statement Michael Halcrow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719215347.GA14091@halcrow.austin.ibm.com \
--to=mhalcrow@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@halcrow.us \
--cc=pregan@ic.sunysb.edu \
--cc=sergeh@us.ibm.com \
--cc=tchicks@us.ibm.com \
--cc=toml@us.ibm.com \
--cc=trevor.highland@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome