From: TAKADA Yoshihito <takada@mbf.nifty.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, teheo@novell.com
Subject: Re: i386: pata_cs5520 does not work
Date: Fri, 20 Jul 2007 09:45:53 +0900 [thread overview]
Message-ID: <20070720004553.15709.qmail@smb518.nifty.com> (raw)
In-Reply-To: <20070719161821.5206ac36@the-village.bc.nu>
Hi.
That's good. It seems to works fine.
On Thu, 19 Jul 2007 16:18:21 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> O> > rc = devm_request_irq(&pdev->dev, irq[ap->port_no],
> > > ata_interrupt, 0, DRV_NAME, host);
> >
> > devm_request_irq() is called twice from loop.
> > In 1st time, ap->port_no is 0. devm_request_irq() is success.
> > 2nd time, ap->port_no is 0 too. devm_request_irq() failed.
>
> Looks like whoever updated it to the new probe mechanism didn't quite get
> it right
>
> Change it to use
>
> struct ata_port *ap = host->ports[i];
>
> not ports[0]
>
> Alan
--
TAKADA <takada@mbf.nifty.com>
next prev parent reply other threads:[~2007-07-20 0:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 16:41 TAKADA Yoshihito
2007-07-15 17:39 ` Alan Cox
2007-07-16 0:19 ` TAKADA Yoshihito
2007-07-18 13:42 ` Alan Cox
2007-07-18 17:20 ` TAKADA Yoshihito
[not found] ` <20070719015806.8B09.TAKADA@mbf.nifty.com>
2007-07-19 10:08 ` TAKADA Yoshihito
2007-07-19 15:18 ` Alan Cox
2007-07-20 0:45 ` TAKADA Yoshihito [this message]
2007-07-20 1:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720004553.15709.qmail@smb518.nifty.com \
--to=takada@mbf.nifty.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=teheo@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®