From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Juergen Beisert <juergen127@kreuzholzen.de>,
Andres Salomon <dilinger@queued.net>,
TAKADA Yoshihito <takada@mbf.nifty.com>,
linux-kernel@vger.kernel.org,
Jordan Crouse <jordan.crouse@amd.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/1] i386: Geode's TSC is not neccessary to mark tu unstable
Date: Fri, 20 Jul 2007 11:21:18 -0700 [thread overview]
Message-ID: <20070720112118.0521ecf5.akpm@linux-foundation.org> (raw)
In-Reply-To: <p73ir8gwl7g.fsf@bingen.suse.de>
On 19 Jul 2007 15:56:51 +0200
Andi Kleen <andi@firstfloor.org> wrote:
> Juergen Beisert <juergen127@kreuzholzen.de> writes:
>
> > Hi Andi,
> >
> > On Thursday 19 July 2007 11:25, Andi Kleen wrote:
> > > On Thursday 19 July 2007 10:52:48 Juergen Beisert wrote:
> > > > On Thursday 19 July 2007 10:22, Andi Kleen wrote:
> > > > > > Wow, that's a really cool bug; nice work! Don't forget to update
> > > > > > arch/i386/kernel/cpu/mtrr/state.c, though; it uses setCx86() as well.
> > > > > > It needs to include processor-cyrix.h.
> > > > >
> > > > > It also needs some big fat comments
> > > >
> > > > No problem. Where to add?
> > >
> > > Where the inlines are defined.
> > >
> > > Also can you please resubmit full patches with full description
> > > and Signed off lines, not incrementals? Thanks.
> >
> > Find attached. Hope its ok now.
>
> For future reference:
> - Please send the patches inline if possible
+1!
> - Generate them from top level (so path start with linux...)
+2!
>
> I fixed it all up
I have a sad little patch from Nick here which adds a new
include/asm-x86_64/processor-cyrix.h. I guess this patch broke the x86_64
build.
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 2 +-
arch/i386/kernel/cpu/cyrix.c | 2 +-
arch/i386/kernel/cpu/mtrr/cyrix.c | 1 +
arch/i386/kernel/cpu/mtrr/state.c | 1 +
include/asm-i386/processor-cyrix.h | 30 ++++++++++++++++++++++++++++++
include/asm-i386/processor.h | 11 -----------
include/asm-x86_64/processor.h | 11 -----------
Some of those .c files will be used by x86_64 too.
next prev parent reply other threads:[~2007-07-20 18:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 12:00 TAKADA Yoshihito
2007-07-15 19:06 ` Juergen Beisert
2007-07-15 23:59 ` TAKADA Yoshihito
2007-07-19 1:02 ` Andrew Morton
2007-07-19 6:49 ` Juergen Beisert
2007-07-19 7:17 ` Andres Salomon
2007-07-19 8:22 ` Andi Kleen
2007-07-19 8:52 ` Juergen Beisert
2007-07-19 9:25 ` Andi Kleen
2007-07-19 10:25 ` Juergen Beisert
2007-07-19 13:56 ` Andi Kleen
2007-07-20 18:21 ` Andrew Morton [this message]
2007-07-20 21:16 ` Andi Kleen
2007-07-22 16:17 ` Satyam Sharma
2007-07-19 8:52 ` Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720112118.0521ecf5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=dilinger@queued.net \
--cc=jordan.crouse@amd.com \
--cc=juergen127@kreuzholzen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=takada@mbf.nifty.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome