From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kristian Hoegsberg <krh@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] idr_remove_all: kill unused variable
Date: Fri, 20 Jul 2007 20:36:06 +0400 [thread overview]
Message-ID: <20070720163606.GA2672@tv-sign.ru> (raw)
"error" is always equal to 0.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- t/lib/idr.c~ 2007-07-20 20:18:09.000000000 +0400
+++ t/lib/idr.c 2007-07-20 20:19:27.000000000 +0400
@@ -405,7 +405,7 @@ EXPORT_SYMBOL(idr_remove);
*/
void idr_remove_all(struct idr *idp)
{
- int n, id, max, error = 0;
+ int n, id, max;
struct idr_layer *p;
struct idr_layer *pa[MAX_LEVEL];
struct idr_layer **paa = &pa[0];
@@ -415,7 +415,7 @@ void idr_remove_all(struct idr *idp)
max = 1 << n;
id = 0;
- while (id < max && !error) {
+ while (id < max) {
while (n > IDR_BITS && p) {
n -= IDR_BITS;
*paa++ = p;
reply other threads:[~2007-07-20 16:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720163606.GA2672@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®