From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: sdhci-devel@list.drzeus.cx,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: SDHCI: mmc0: Unexpected interrupt 0x00008000.
Date: Fri, 20 Jul 2007 18:22:03 +0200 [thread overview]
Message-ID: <20070720182203.3f378d58@poseidon.drzeus.cx> (raw)
In-Reply-To: <469FB856.6030000@goop.org>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
On Thu, 19 Jul 2007 12:15:34 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> I'm getting this with current GIT kernels when I plug an SD card into
> the side of my machine. It appears to see the filesystem OK anyway,
> but for some reason all the hal/gnome desktop stuff isn't seeing it.
> Was working last week.
>
This appeared because we fixed another bug. Try the included patch.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
[-- Attachment #2: errmask.patch --]
[-- Type: text/x-patch, Size: 1367 bytes --]
commit 0668da722a0c48e8629d697fa354e23a02548093
Author: Pierre Ossman <drzeus@drzeus.cx>
Date: Fri Jul 20 18:20:36 2007 +0200
sdhci: make sure to clear the error interrupt
The controller has a bit indicating that one of the higher bits (the
error bits) are set. A previous bug caused this bit to be masked, but
since that bug has been fixed we have to clear it explicictly.
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 10d15c3..4a24db0 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1024,6 +1024,8 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id)
intmask &= ~(SDHCI_INT_CMD_MASK | SDHCI_INT_DATA_MASK);
+ intmask &= ~SDHCI_INT_ERROR;
+
if (intmask & SDHCI_INT_BUS_POWER) {
printk(KERN_ERR "%s: Card is consuming too much power!\n",
mmc_hostname(host->mmc));
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 7400f4b..a6c8704 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -107,6 +107,7 @@
#define SDHCI_INT_CARD_INSERT 0x00000040
#define SDHCI_INT_CARD_REMOVE 0x00000080
#define SDHCI_INT_CARD_INT 0x00000100
+#define SDHCI_INT_ERROR 0x00008000
#define SDHCI_INT_TIMEOUT 0x00010000
#define SDHCI_INT_CRC 0x00020000
#define SDHCI_INT_END_BIT 0x00040000
prev parent reply other threads:[~2007-07-20 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 19:15 Jeremy Fitzhardinge
2007-07-20 16:22 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720182203.3f378d58@poseidon.drzeus.cx \
--to=drzeus-mmc@drzeus.cx \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sdhci-devel@list.drzeus.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome