From: "Hans-Jürgen Koch" <hjk@linutronix.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: drivers/hwmon/lm93.c: array overruns
Date: Mon, 23 Jul 2007 09:36:57 +0200 [thread overview]
Message-ID: <200707230936.58135.hjk@linutronix.de> (raw)
In-Reply-To: <20070723005453.GS26212@stusta.de>
Am Montag 23 Juli 2007 02:54 schrieb Adrian Bunk:
> The Coverity checker spotted the following array overruns
> in drivers/hwmon/lm93.c:
>
> <-- snip -->
>
> ...
> struct lm93_data {
> ...
> struct {
> u8 min;
> u8 max;
> } temp_lim[3];
> ...
> };
> ...
> static void lm93_update_client_common(struct lm93_data *data,
> struct i2c_client *client)
> {
> ...
> for (i = 0; i < 4; i++) {
> data->temp_lim[i].min =
> lm93_read_byte(client, LM93_REG_TEMP_MIN(i));
> data->temp_lim[i].max =
> lm93_read_byte(client, LM93_REG_TEMP_MAX(i));
> }
> ...
>
> <-- snip -->
This patch should fix it. Thanks a lot, Adrian!
----
This fixes an array overflow bug. We have 4 pairs of min/max temperature
limits, not 3.
Signed-off-by: Hans J. Koch <hjk@linutronix.de>
--
Index: linux-2.6.23-rc/drivers/hwmon/lm93.c
===================================================================
--- linux-2.6.23-rc.orig/drivers/hwmon/lm93.c 2007-07-23 09:22:56.000000000 +0200
+++ linux-2.6.23-rc/drivers/hwmon/lm93.c 2007-07-23 09:29:37.000000000 +0200
@@ -234,7 +234,7 @@
struct {
u8 min;
u8 max;
- } temp_lim[3];
+ } temp_lim[4];
/* vin1 - vin16: low and high limits */
struct {
next prev parent reply other threads:[~2007-07-23 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 0:54 Adrian Bunk
2007-07-23 7:36 ` Hans-Jürgen Koch [this message]
2007-07-24 8:10 ` [lm-sensors] " Jean Delvare
2007-07-24 8:26 ` Hans-Jürgen Koch
2007-07-24 12:00 ` Jean Delvare
2007-07-24 13:00 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707230936.58135.hjk@linutronix.de \
--to=hjk@linutronix.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®