From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758491AbXGWMag (ORCPT ); Mon, 23 Jul 2007 08:30:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751132AbXGWMa2 (ORCPT ); Mon, 23 Jul 2007 08:30:28 -0400 Received: from calculon.skynet.ie ([193.1.99.88]:51022 "EHLO calculon.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbXGWMa1 (ORCPT ); Mon, 23 Jul 2007 08:30:27 -0400 Date: Mon, 23 Jul 2007 13:30:24 +0100 To: Peter Zijlstra Cc: Andrew Morton , Linus Torvalds , linux-kernel , Christoph Lameter , Daniel Phillips , linux-mm Subject: Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK Message-ID: <20070723123023.GC19437@skynet.ie> References: <1185185020.8197.11.camel@twins> <20070723112143.GB19437@skynet.ie> <1185190711.8197.15.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1185190711.8197.15.camel@twins> User-Agent: Mutt/1.5.13 (2006-08-11) From: mel@skynet.ie (Mel Gorman) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On (23/07/07 13:38), Peter Zijlstra didst pronounce: > On Mon, 2007-07-23 at 12:21 +0100, Mel Gorman wrote: > > > Does this patch compile though? > > Ugh, the fix landed in another patch :-( > > updated patch below. > > --- > Daniel recently spotted that __GFP_ZERO is not (and has never been) > part of GFP_LEVEL_MASK. I could not find a reason for this in the > original patch: 3977971c7f09ce08ed1b8d7a67b2098eb732e4cd in the -bk > tree. > Missing sign-off but anyway Acked-by: Mel Gorman > This of course is in stark contradiction with the comment accompanying > GFP_LEVEL_MASK. > --- > include/linux/gfp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6-2/include/linux/gfp.h > =================================================================== > --- linux-2.6-2.orig/include/linux/gfp.h > +++ linux-2.6-2/include/linux/gfp.h > @@ -56,7 +56,7 @@ struct vm_area_struct; > /* if you forget to add the bitmask here kernel will crash, period */ > #define GFP_LEVEL_MASK (__GFP_WAIT|__GFP_HIGH|__GFP_IO|__GFP_FS| \ > __GFP_COLD|__GFP_NOWARN|__GFP_REPEAT| \ > - __GFP_NOFAIL|__GFP_NORETRY|__GFP_COMP| \ > + __GFP_NOFAIL|__GFP_NORETRY|__GFP_COMP|__GFP_ZERO| \ > __GFP_NOMEMALLOC|__GFP_HARDWALL|__GFP_THISNODE| \ > __GFP_MOVABLE) > > > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab