From: Christoph Lameter <clameter@sgi.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Adam Litke <agl@us.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>,
Ken Chen <kenchen@google.com>, Bill Irwin <wli@holomorphy.com>
Subject: Re: [PATCH] Check for compound pages in set_page_dirty()
Date: Mon, 23 Jul 2007 13:54:16 -0700 [thread overview]
Message-ID: <20070723135416.44edc896@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0707191720300.10512@blonde.wat.veritas.com>
On Thu, 19 Jul 2007 18:35:17 +0100 (BST)
Hugh Dickins <hugh@veritas.com> wrote:
> I didn't see any attention to set_page_dirty in Christoph's
> Large Blocksize (variable page_cachesize) patches, but I expect
> he'd also be wanting set_page_dirty to act on compound_head.
There is no need for special casing if set_page_dirty() is only
ever called for page heads. Make sure that direct I/O does not call
set_page_dirty for tail pages.
A VM_BUG_ON(PageTail(page)) could be used to make sure that this
does not happen in the future?
next prev parent reply other threads:[~2007-07-23 20:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 14:15 Jens Axboe
2007-07-18 15:40 ` Hugh Dickins
2007-07-18 18:24 ` Jens Axboe
2007-07-18 18:40 ` Jens Axboe
2007-07-18 20:35 ` Hugh Dickins
2007-07-19 6:29 ` Jens Axboe
2007-07-19 8:07 ` Jens Axboe
2007-07-19 17:35 ` Hugh Dickins
2007-07-20 0:34 ` William Lee Irwin III
2007-07-23 20:54 ` Christoph Lameter [this message]
2007-07-26 17:37 ` Hugh Dickins
2007-07-26 17:44 ` Christoph Lameter
2007-07-26 17:59 ` Hugh Dickins
2007-07-26 18:16 ` Christoph Lameter
2007-07-18 18:45 ` Hugh Dickins
2007-07-18 18:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723135416.44edc896@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=david@gibson.dropbear.id.au \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome