From: Andreas Dilger <adilger@clusterfs.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fengguang Wu <fengguang.wu@gmail.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Rusty Russell <rusty@rustcorp.com.au>,
Dave Jones <davej@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel <linux-kernel@vger.kernel.org>,
riel <riel@redhat.com>, Tim Pepper <lnxninja@us.ibm.com>,
Chris Snook <csnook@redhat.com>,
Jens Axboe <jens.axboe@oracle.com>,
linux-ext4@vger.kernel.org, Mingming Cao <cmm@us.ibm.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
Chris Ahna <christopher.j.ahna@intel.com>,
David Mosberger-Tang <davidm@hpl.hp.com>,
Kyle McMartin <kyle@parisc-linux.org>,
Dave Jones <davej@codemonkey.org.uk>,
Dave Airlie <airlied@linux.ie>
Subject: Re: [PATCH 0/3] readahead drop behind and size adjustment
Date: Tue, 24 Jul 2007 02:50:56 -0600 [thread overview]
Message-ID: <20070724085056.GE5992@schatzie.adilger.int> (raw)
In-Reply-To: <20070723181701.c5551449.akpm@linux-foundation.org>
On Jul 23, 2007 18:17 -0700, Andrew Morton wrote:
> hm, yes, there is a risk that the code was accidentally correct. Or the
> code has only ever dealt with power-of-2 inputs, in which case it happens
> to work either way.
>
> David(s) and ext4-people: could we please have a close review of these
> changes?
> > @@ -1706,8 +1704,8 @@ static int ext4_fill_super (struct super
> > - sbi->s_addr_per_block_bits = log2(EXT4_ADDR_PER_BLOCK(sb));
> > - sbi->s_desc_per_block_bits = log2(EXT4_DESC_PER_BLOCK(sb));
> > + sbi->s_addr_per_block_bits = ilog2(EXT4_ADDR_PER_BLOCK(sb));
> > + sbi->s_desc_per_block_bits = ilog2(EXT4_DESC_PER_BLOCK(sb));
For the ext[234] code there has only ever been power-of-two values for
ADDR_PER_BLOCK() and DESC_PER_BLOCK().
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2007-07-24 8:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 21:00 Peter Zijlstra
2007-07-21 21:00 ` [PATCH 1/3] readahead: drop behind Peter Zijlstra
2007-07-21 20:29 ` Eric St-Laurent
2007-07-21 20:37 ` Peter Zijlstra
2007-07-21 20:59 ` Eric St-Laurent
2007-07-21 21:06 ` Peter Zijlstra
2007-07-25 3:55 ` Eric St-Laurent
2007-07-21 21:00 ` [PATCH 2/3] readahead: fadvise drop behind controls Peter Zijlstra
2007-07-21 21:00 ` [PATCH 3/3] readahead: scale max readahead size depending on memory size Peter Zijlstra
2007-07-22 8:24 ` Jens Axboe
2007-07-22 8:36 ` Peter Zijlstra
2007-07-22 8:50 ` Jens Axboe
2007-07-22 9:17 ` Peter Zijlstra
2007-07-22 16:44 ` Jens Axboe
2007-07-23 10:04 ` Jörn Engel
2007-07-23 10:11 ` Jens Axboe
2007-07-23 22:44 ` Rusty Russell
2007-07-22 23:52 ` Rik van Riel
2007-07-23 5:22 ` Jens Axboe
[not found] ` <20070722084526.GB6317@mail.ustc.edu.cn>
2007-07-22 8:45 ` Fengguang Wu
2007-07-22 8:59 ` Peter Zijlstra
[not found] ` <20070722095313.GA8136@mail.ustc.edu.cn>
2007-07-22 9:53 ` Fengguang Wu
[not found] ` <20070722023923.GA6438@mail.ustc.edu.cn>
2007-07-22 2:39 ` [PATCH 0/3] readahead drop behind and size adjustment Fengguang Wu
2007-07-22 2:44 ` Dave Jones
[not found] ` <20070722081010.GA6317@mail.ustc.edu.cn>
2007-07-22 8:10 ` Fengguang Wu
2007-07-22 8:24 ` Peter Zijlstra
[not found] ` <20070722082923.GA7790@mail.ustc.edu.cn>
2007-07-22 8:29 ` Fengguang Wu
2007-07-22 8:33 ` Rusty Russell
2007-07-22 8:45 ` Peter Zijlstra
2007-07-23 9:00 ` Nick Piggin
[not found] ` <20070723142457.GA10130@mail.ustc.edu.cn>
2007-07-23 14:24 ` Fengguang Wu
2007-07-23 19:40 ` Andrew Morton
[not found] ` <20070724004728.GA8026@mail.ustc.edu.cn>
2007-07-24 0:47 ` Fengguang Wu
2007-07-24 1:17 ` Andrew Morton
2007-07-24 8:50 ` Andreas Dilger [this message]
2007-07-24 4:30 ` Nick Piggin
2007-07-25 4:35 ` Eric St-Laurent
2007-07-25 5:19 ` Nick Piggin
2007-07-25 6:18 ` Eric St-Laurent
2007-07-25 7:09 ` Nick Piggin
2007-07-25 7:48 ` Eric St-Laurent
2007-07-25 15:36 ` Rik van Riel
2007-07-25 15:33 ` Rik van Riel
2007-07-29 7:44 ` Eric St-Laurent
2007-07-25 15:28 ` Rik van Riel
2007-07-22 11:11 Al Boldi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724085056.GE5992@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=a.p.zijlstra@chello.nl \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=christopher.j.ahna@intel.com \
--cc=cmm@us.ibm.com \
--cc=csnook@redhat.com \
--cc=davej@codemonkey.org.uk \
--cc=davej@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=fengguang.wu@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=kyle@parisc-linux.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lnxninja@us.ibm.com \
--cc=nickpiggin@yahoo.com.au \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®