From: Oleg Nesterov <oleg@tv-sign.ru>
To: Jeremy Katz <jeremy.katz@windriver.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Ingo Molnar <mingo@elte.hu>, Stable Team <stable@kernel.org>
Subject: Re: [PATCH] posix-timer: fix deletion race
Date: Tue, 24 Jul 2007 18:51:42 +0400 [thread overview]
Message-ID: <20070724145142.GA199@tv-sign.ru> (raw)
In-Reply-To: <Pine.LNX.4.63.0707231858420.9759@localhost.localdomain>
On 07/23, Jeremy Katz wrote:
>
> On Fri, 20 Jul 2007, Oleg Nesterov wrote:
>
> >I still can't believe we have a double-free problem, this looks imposiible.
> >Do you see the
> >
> > "idr_remove called for id=%d which is not allocated.\n"
> >
> >in syslog?
>
> No. I also added some accounting with atomic counters, and don't see
> evidence of a second call to release_posix_timer.
Interesting. Could you show the patch? Where does sys_timer_create() set
counter == 1?
> >Could you try the patch below? Perhaps we have some wierd problem with
> >->sigq corruption.
>
> Tried, with apparent effect.
You mean, "null pointer dereference" in release_posix_timer() ? Or it was
BUG_ON(timr && !timr->sigq) in lock_timer() ?
I assume you didn't apply any other patches except Thomas's, yes?
Oleg.
next prev parent reply other threads:[~2007-07-24 14:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 18:19 POSIX timer deletion race? Jeremy Katz
2007-07-17 8:53 ` [PATCH] posix-timer: fix deletion race Thomas Gleixner
2007-07-17 9:57 ` Ingo Molnar
2007-07-17 18:29 ` Jeremy Katz
2007-07-17 13:07 ` Oleg Nesterov
2007-07-17 17:02 ` Thomas Gleixner
2007-07-17 18:39 ` Jeremy Katz
2007-07-17 20:17 ` Thomas Gleixner
2007-07-17 23:12 ` Jeremy Katz
2007-07-17 23:58 ` Jeremy Katz
2007-07-18 6:05 ` Thomas Gleixner
2007-07-18 6:58 ` Thomas Gleixner
2007-07-18 19:02 ` Jeremy Katz
2007-07-18 23:43 ` Jeremy Katz
2007-07-19 5:50 ` Thomas Gleixner
2007-07-19 19:24 ` Jeremy Katz
2007-07-18 16:11 ` Oleg Nesterov
2007-07-18 19:08 ` Jeremy Katz
2007-07-20 14:15 ` Oleg Nesterov
2007-07-24 2:07 ` Jeremy Katz
2007-07-24 14:51 ` Oleg Nesterov [this message]
2007-07-24 18:36 ` Jeremy Katz
2007-07-24 20:43 ` Oleg Nesterov
2007-07-24 21:19 ` Jeremy Katz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724145142.GA199@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=jeremy.katz@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®