From: David Miller <davem@davemloft.net>
To: matthew@wil.cx
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: IRQF_DISABLED problem
Date: Thu, 26 Jul 2007 15:23:52 -0700 (PDT) [thread overview]
Message-ID: <20070726.152352.70218024.davem@davemloft.net> (raw)
In-Reply-To: <20070726201355.GP19275@parisc-linux.org>
From: Matthew Wilcox <matthew@wil.cx>
Date: Thu, 26 Jul 2007 14:13:56 -0600
>
> I noticed that we only look at the first action in the chain when
> determining whether to re-enable local interrupts during handle_IRQ_event.
> But we don't try to exclude sharing interrupts with mixtures of
> IRQF_DISABLED set and clear. I just tried to do that locally, and one
> of my USB ports disappears, because it shares an interrupt with qla2xxx
> which sets IRQF_DISABLED, and UHCI doesn't.
>
> Another possibility is to force it if *any* of the handlers want
> IRQF_DISABLED. This seems to work:
Yes, this is consistent with how we handle sharing, we should
enforce that all the flags on the chain are compatible.
next prev parent reply other threads:[~2007-07-27 0:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 20:13 Matthew Wilcox
2007-07-26 20:41 ` Linus Torvalds
2007-07-26 22:23 ` David Miller [this message]
2007-07-26 23:04 ` Linus Torvalds
2007-07-26 23:14 ` David Miller
2007-07-26 23:17 ` Linus Torvalds
2007-07-27 20:11 ` Arjan van de Ven
2007-07-27 20:50 ` David Miller
[not found] <fa.mb8woD3e5JnT1x6AgEMOmnlVvg0@ifi.uio.no>
[not found] ` <fa.axY2ukp7kqKVMAidyu4NVN81MbI@ifi.uio.no>
[not found] ` <fa.tS+LCGnYgeCNRIaF90yH21XBCqI@ifi.uio.no>
[not found] ` <fa./08N/HtpJQ6zg8Xc1K5pP6/aKMM@ifi.uio.no>
2007-07-29 15:41 ` Robert Hancock
2007-08-02 15:40 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726.152352.70218024.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®