From: Joe Jin <joe.jin@oracle.com>
To: akpm@linux-foundation.org, torvalds@linux-foundation.org,
jens.axboe@oracle.com
Cc: linux-kernel@vger.kernel.org, gurudas.pai@oracle.com,
wen.gang.wang@oracle.com, joe.jin@oracle.com
Subject: [PATCH] add check do_direct_IO() return val
Date: Thu, 26 Jul 2007 17:04:00 +0800 [thread overview]
Message-ID: <20070726090400.GA18640@joejin-pc.cn.oracle.com> (raw)
This is the patch for check do_direct_IO() return val.
At do_direct_IO(), sometimes dio_get_page() will return -EFAULT/-ENOMEM,
according to orig source, it will go on left work. buf for dio_get_page()
return a error will made many useful member of dio not initialized like
dio->map_bh and others, at this point, kernel will panic.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
---
--- linux-2.6.22/fs/direct-io.c.orig 2007-07-26 11:32:27.000000000 +0800
+++ linux-2.6.22/fs/direct-io.c 2007-07-26 11:33:58.000000000 +0800
@@ -1031,7 +1031,9 @@ direct_io_worker(int rw, struct kiocb *i
((dio->final_block_in_request - dio->block_in_file) <<
blkbits);
- if (ret) {
+ if (ret == -EFAULT || ret == -ENOMEM)
+ goto out;
+ else if (ret) {
dio_cleanup(dio);
break;
}
@@ -1113,6 +1115,7 @@ direct_io_worker(int rw, struct kiocb *i
} else
BUG_ON(ret != -EIOCBQUEUED);
+out:
return ret;
}
next reply other threads:[~2007-07-26 9:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 9:04 Joe Jin [this message]
2007-07-27 5:13 ` Andrew Morton
2007-07-27 7:15 ` Joe Jin
2007-07-27 7:31 ` Dave Young
2007-07-27 7:44 ` Joe Jin
2007-07-27 12:37 ` gurudas pai
2007-07-28 3:47 ` Joe Jin
2007-07-30 20:53 ` Andrew Morton
2007-07-30 21:09 ` Zach Brown
2007-07-30 21:24 ` Badari Pulavarty
2007-07-30 21:45 ` Zach Brown
2007-07-30 21:58 ` Badari Pulavarty
2007-07-30 21:58 ` Zach Brown
2007-07-30 23:38 ` Zach Brown
2007-07-31 0:15 ` Badari Pulavarty
2007-07-31 0:17 ` Badari Pulavarty
2007-07-31 0:53 ` Joe Jin
2007-07-31 3:45 ` Badari
2007-07-31 4:35 ` Joe Jin
2007-07-31 5:01 ` Badari
2007-07-31 22:25 ` Badari Pulavarty
2007-07-31 22:34 ` Andrew Morton
2007-07-31 22:59 ` Linus Torvalds
2007-07-31 23:16 ` Zach Brown
2007-08-01 1:36 ` Joe Jin
2007-08-01 11:40 ` gurudas pai
2007-07-31 23:04 ` Badari Pulavarty
2007-07-31 23:14 ` Zach Brown
2007-08-01 1:11 ` Joe Jin
2007-07-27 8:09 ` gurudas pai
2007-07-27 5:13 ` wengang wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726090400.GA18640@joejin-pc.cn.oracle.com \
--to=joe.jin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=gurudas.pai@oracle.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wen.gang.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®