From: Sam Ravnborg <sam@ravnborg.org>
To: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Cc: Roland Dreier <rdreier@cisco.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
general@lists.openfabrics.org, raisch@de.ibm.com,
stefan.roscher@de.ibm.com
Subject: Re: [PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"
Date: Fri, 27 Jul 2007 13:01:18 +0200 [thread overview]
Message-ID: <20070727110118.GB12647@uranus.ravnborg.org> (raw)
In-Reply-To: <200707271254.51055.hnguyen@linux.vnet.ibm.com>
On Fri, Jul 27, 2007 at 12:54:50PM +0200, Hoang-Nam Nguyen wrote:
> >From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001
> From: Hoang-Nam Nguyen <hnguyen at de.ibm.com>
> Date: Fri, 27 Jul 2007 10:24:49 +0200
> Subject: [PATCH] remove checkpatch.pl's warnings "externs should be avoided in .c files"
>
> Signed-off-by: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
And you checked that said .h file was indeed included by the .c file that has the original definition?
Otherwise the definition and the declaration can get out of sync without notice.
Sam
next prev parent reply other threads:[~2007-07-27 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 10:54 Hoang-Nam Nguyen
2007-07-27 11:01 ` Sam Ravnborg [this message]
2007-07-29 3:39 ` [ofa-general] " Roland Dreier
2007-07-30 13:07 ` Hoang-Nam Nguyen
2007-07-30 13:54 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070727110118.GB12647@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=general@lists.openfabrics.org \
--cc=hnguyen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=raisch@de.ibm.com \
--cc=rdreier@cisco.com \
--cc=stefan.roscher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®