mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Russell King" <rmk@arm.linux.org.uk>,
	"Adam Belay" <ambx1@neo.rr.com>, "Len Brown" <lenb@kernel.org>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Sébastien Dugué" <sebastien.dugue@bull.net>,
	"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] x86, serial: always probe for legacy COM ports
Date: Fri, 27 Jul 2007 14:11:41 -0600	[thread overview]
Message-ID: <200707271411.42253.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <46AA33FF.4070504@garzik.org>

On Friday 27 July 2007 12:05:51 pm Jeff Garzik wrote:
> Bjorn Helgaas wrote:
> > Andrew, if you drop
> >     revert-x86-serial-convert-legacy-com-ports-to-platform-devices.patch
> > and apply this, we should have the previous behavior.  I think the
> > conversion to platform devices is still worthwhile.  Obviously, I intend
> > this as 2.6.23 material.
> > 
> > 
> > Always probe for serial ports at legacy addresses, even if we have PNPBIOS
> > or ACPI that should tell us about those ports.
> > 
> > We have no reports yet of defective firmware that completely omits ports.
> > However, Sébastien Dugué <sebastien.dugue@bull.net> reported that the
> > NEC Express5800/120Lh with Phoenix BIOS 6.0.5N52, released 7/12/2005,
> > reports COM2 first, then COM1 in the ACPI namespace.
> > 
> > 8250_pnp currently registers devices in namespace order.  On this machine,
> > that makes ttyS0=COM2 and ttyS1=COM1, the reverse of what we want.
> > 
> > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> 
> This is still incomplete, as repeatedly stated.  Here is the email, again.

OK, uncle!  I'll work on your helpful advice (thanks for that), but
it feels too risky for this stage of 2.6.23.  Maybe I can come up with
something for a future release.

Bjorn

  reply	other threads:[~2007-07-27 20:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27 17:58 Bjorn Helgaas
2007-07-27 18:05 ` Jeff Garzik
2007-07-27 20:11   ` Bjorn Helgaas [this message]
2007-07-27 20:21     ` Jeff Garzik
2007-07-27 20:26       ` Bjorn Helgaas
2007-07-27 20:35         ` Andrew Morton
2007-07-27 20:49         ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707271411.42253.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ambx1@neo.rr.com \
    --cc=jeff@garzik.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=sebastien.dugue@bull.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®