Re: [PATCH] Fix msr register allocation

["Björn Steinbrink" <B.Steinbrink@gmx.de>]

On 2007.07.30 12:25:54 -0300, Glauber de Oliveira Costa wrote:
> Since the value in ret will go through a return statement,
                     ^^^
You mean "err" I guess?

> it does not need to be put in eax register directly. Instead,
> we let the compiler do his job and choose what to do with it,
> potentially getting a better register allocation.
>     
> Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
> 
> diff --git a/include/asm-i386/msr.h b/include/asm-i386/msr.h
> index df21ea0..cc4263c 100644
> --- a/include/asm-i386/msr.h
> +++ b/include/asm-i386/msr.h
> @@ -54,7 +54,7 @@ static inline int native_write_msr_safe(unsigned int msr,
>  		     "   .align 4\n\t"
>  		     "   .long 	2b,3b\n\t"
>  		     ".previous"
> -		     : "=a" (err)
> +		     : "=r" (err)
>  		     : "c" (msr), "0" ((u32)val), "d" ((u32)(val>>32)),
>  		       "i" (-EFAULT));
>  	return err;

Note that the EAX output constraint is re-used in the input section for
(u32)val, i.e. the lower half of the value to be written. And "wrmsr"
needs that in EAX, so you cannot change the output constraint without
touching the input constraint.

Also, I do not see how the compiler could do any better than having the
return value already in EAX, but that doesn't really mean anything ;-)

Björn