From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756102AbXGaJZE (ORCPT ); Tue, 31 Jul 2007 05:25:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752363AbXGaJYx (ORCPT ); Tue, 31 Jul 2007 05:24:53 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:56890 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbXGaJYw (ORCPT ); Tue, 31 Jul 2007 05:24:52 -0400 From: "Rafael J. Wysocki" To: Pavel Machek Subject: Re: [PATCH] create CONFIG_SUSPEND_UP_POSSIBLE Date: Tue, 31 Jul 2007 11:33:26 +0200 User-Agent: KMail/1.9.5 Cc: Len Brown , Linus Torvalds , david@lang.hm, Andrew Morton , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Adrian Bunk , Stefan Richter , Nigel Cunningham , pm list References: <200707251238.50218.lenb@kernel.org> <200707302354.23237.lenb@kernel.org> <20070731063833.GD22419@elf.ucw.cz> In-Reply-To: <20070731063833.GD22419@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200707311133.27963.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, 31 July 2007 08:38, Pavel Machek wrote: > Hi! > > > Without this change, it is possible to build CONFIG_HIBERNATE > > on all !SMP architectures, but not necessarily their SMP versions. > > Did you want to say "CONFIG_SUSPEND"? > > > I don't know for sure if the architecture list under SUSPEND_UP_POSSIBLE > > is correct. For now it simply matches the list for > > SUSPEND_SMP_POSSIBLE. > > I do not think it is. No, it's not. > > Signed-off-by: Len Brown > > --- > > Kconfig | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig > > index 412859f..ccf6576 100644 > > --- a/kernel/power/Kconfig > > +++ b/kernel/power/Kconfig > > @@ -72,6 +72,11 @@ config PM_TRACE > > CAUTION: this option will cause your machine's real-time clock to be > > set to an invalid time after a resume. > > > > +config SUSPEND_UP_POSSIBLE > > + bool > > + depends on (X86 && !X86_VOYAGER) || (PPC64 && (PPC_PSERIES || > > At least ARM can do suspend, too... probably others. ARM, frv, sh, mips and blackfin (AFAICS). > I was under impression that SUSPEND is "supported" by all the architectures, > just some of them veto it at runtime (using pm_ops or how was it renamed). Historically, suspend support was implied by CONFIG_PM. For now, it's not much point in using CONFIG_PM at all if the arch in question doesn't support suspending or hibernation, so I thought it would be better to leave it unrestricted. Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth