Re: [Patch 04/16] Remove unnecessary kmalloc casts from the sparc arch.

[WANG Cong <xiyou.wangcong@gmail.com>]

On Tue, Jul 31, 2007 at 01:53:20PM +0100, jack@hawkeye.stone.uk.eu.org wrote:
>Signed-off-by: Jack Stone <jack@hawkeye.stone.uk.eu.org>
>
>CC: David Miller <davem@davemloft.net>
>
>---
> arch/sparc/kernel/ebus.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>Index: b/arch/sparc/kernel/ebus.c
>===================================================================
>--- a/arch/sparc/kernel/ebus.c
>+++ b/arch/sparc/kernel/ebus.c
>@@ -64,7 +64,7 @@ static struct ebus_device_irq *ebus_blac
>  */
> static inline unsigned long ebus_alloc(size_t size)
> {
>-	return (unsigned long)kmalloc(size, GFP_ATOMIC);
>+	return kmalloc(size, GFP_ATOMIC);

AFAIK, this cast is necessary, since void * is a pointer type while
unsigned long is not.

Regards.

-- 
To do great work, you have to have a pure mind. You can think only about the
mathematics. Everything else is human weakness. Accepting prizes is showing
weakness.