From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Tejun Heo <htejun@gmail.com>
Cc: ebiederm@xmission.com, gregkh@suse.de,
linux-kernel@vger.kernel.org, satyam@infradead.org,
stern@rowland.harvard.edu
Subject: Re: [PATCH 5/7] sysfs: make sysfs_add/remove_one() call link/unlink_sibling() implictly
Date: Tue, 31 Jul 2007 15:13:11 +0200 [thread overview]
Message-ID: <20070731151311.1e02626b@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <11858769082486-git-send-email-htejun@gmail.com>
On Tue, 31 Jul 2007 19:15:08 +0900,
Tejun Heo <htejun@gmail.com> wrote:
> When adding or removing a sysfs_dirent, the user used to be required
> to call link/unlink separately. It was for two reasons - code looked
> like that before sysfs_addrm_cxt conversion and to avoid looping
> through parent_sd->children list twice during removal.
>
> Performance optimization during removal just isn't worth it. Make
> sysfs_add/remove_one() call sysfs_link/unlink_sibing() implicitly.
> This makes code simpler albeit slightly less efficient. This change
> doesn't introduce any noticeable behavior change.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> fs/sysfs/dir.c | 21 ++++++++++-----------
> fs/sysfs/file.c | 4 +---
> fs/sysfs/inode.c | 17 ++++-------------
> fs/sysfs/symlink.c | 4 +---
> fs/sysfs/sysfs.h | 2 --
> 5 files changed, 16 insertions(+), 32 deletions(-)
>
I agree. The double loop in the removal path doesn't really hurt, and
the code is now much nicer.
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2007-07-31 13:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 10:15 [PATCHSET 2.6.23-rc1] sysfs: locking fix and cleanups Tejun Heo
2007-07-31 10:15 ` [PATCH 6/7] sysfs: make sysfs_add_one() automatically check for duplicate entry Tejun Heo
2007-07-31 13:25 ` Cornelia Huck
2007-07-31 10:15 ` [PATCH 5/7] sysfs: make sysfs_add/remove_one() call link/unlink_sibling() implictly Tejun Heo
2007-07-31 13:13 ` Cornelia Huck [this message]
2007-07-31 10:15 ` [PATCH 1/7] sysfs: fix locking in sysfs_lookup() and sysfs_rename_dir() Tejun Heo
2007-07-31 12:56 ` Cornelia Huck
2007-08-02 0:29 ` Greg KH
2007-08-02 1:10 ` Eric W. Biederman
2007-08-02 1:10 ` Greg KH
2007-07-31 10:15 ` [PATCH 3/7] sysfs: cosmetic changes in sysfs_lookup() Tejun Heo
2007-07-31 12:57 ` Cornelia Huck
2007-07-31 10:15 ` [PATCH 4/7] sysfs: simplify sysfs_remove_dir() Tejun Heo
2007-07-31 12:59 ` Cornelia Huck
2007-07-31 13:22 ` Tejun Heo
2007-07-31 10:15 ` [PATCH 7/7] sysfs: make sysfs_addrm_finish() return void Tejun Heo
2007-07-31 12:55 ` Satyam Sharma
2007-07-31 13:33 ` Cornelia Huck
2007-07-31 12:55 ` [PATCHSET 2.6.23-rc1] sysfs: locking fix and cleanups Cornelia Huck
2007-07-31 13:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070731151311.1e02626b@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=satyam@infradead.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®