From: Mikael Pettersson <mikpe@it.uu.se>
To: buytenh@wantstofly.org, mikpe@it.uu.se
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
rmk@arm.linux.org.uk, tglx@linutronix.de
Subject: Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP
Date: Thu, 2 Aug 2007 02:06:27 +0200 (MEST) [thread overview]
Message-ID: <200708020006.l7206RoY009376@harpo.it.uu.se> (raw)
On Thu, 2 Aug 2007 01:49:02 +0200, Lennert Buytenhek wrote:
> On Thu, Aug 02, 2007 at 01:00:21AM +0200, Mikael Pettersson wrote:
>
> > @@ -52,7 +53,34 @@ futex_atomic_op_inuser (int encoded_op,
> > static inline int
> > futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval)
> > {
> > +#ifdef CONFIG_SMP
> > return -ENOSYS;
> > +#else
>
> Since the callers of futex_atomic_cmpxchg_inatomic() don't really
> seem prepared to deal with -ENOSYS (e.g. the handle_futex_death()
> infinite loop when it gets -ENOSYS), it seems better never to
> return -ENOSYS from this function at all.
>
> What if you just stick an #error in here in the SMP case?
The problem with #error is that it would cause compile-time
regressions. I assume that e.g. alpha supports building SMP
kernels, but #error would prevent that.
Thus I opted to fix the UP case while leaving the SMP case
unchanged. Actually I think the SMP case should be a BUG()
rather than -ENOSYS, but that's a different issue from the
UP case which I really do want to see fixed.
/Mikael
next reply other threads:[~2007-08-02 0:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 0:06 Mikael Pettersson [this message]
2007-08-02 0:58 ` Lennert Buytenhek
-- strict thread matches above, loose matches on Subject: below --
2007-10-04 7:41 Mikael Pettersson
2007-10-04 8:07 ` Geert Uytterhoeven
2007-08-01 23:00 Mikael Pettersson
2007-08-01 23:49 ` Lennert Buytenhek
2007-10-03 19:33 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708020006.l7206RoY009376@harpo.it.uu.se \
--to=mikpe@it.uu.se \
--cc=buytenh@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rmk@arm.linux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®