From: Oleg Nesterov <oleg@tv-sign.ru>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Nigel Cunningham <nigel@nigel.suspend2.net>,
Pavel Machek <pavel@ucw.cz>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping (updated)
Date: Fri, 3 Aug 2007 01:23:07 +0400 [thread overview]
Message-ID: <20070802212307.GA521@tv-sign.ru> (raw)
In-Reply-To: <200708022313.32944.rjw@sisk.pl>
On 08/02, Rafael J. Wysocki wrote:
>
> On Thursday, 2 August 2007 20:40, Oleg Nesterov wrote:
> > On 08/02, Rafael J. Wysocki wrote:
> > >
> > > @@ -171,6 +186,10 @@ static int try_to_freeze_tasks(int freez
> > >
> > > end_time = jiffies + TIMEOUT;
> > > do {
> > > + DEFINE_WAIT(wait);
> > > +
> > > + add_wait_queue(&refrigerator_waitq, &wait);
> >
> > Hmm. In that case I'd sugest to use prepare_to_wait(). This means that
> > multiple wakeups from refrigerator() won't do unnecessary work,
>
> I'm not sure what you mean.
>
> Do you mean that if we are TASK_UNINTERRUPTIBLE, then the first wake up
> should remove us from the queue?
No, not because we are TASK_UNINTERRUPTIBLE, but yes, first wake up will
remove us because DEFINE_WAIT() uses autoremove_wake_function().
Oleg.
next prev parent reply other threads:[~2007-08-02 21:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 21:28 [PATCH -mm 0/3] Freezer: Use wait queue instead of busy looping Rafael J. Wysocki
2007-08-01 21:30 ` [PATCH -mm 1/3] Freezer: Be more verbose Rafael J. Wysocki
2007-08-01 21:32 ` [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping Rafael J. Wysocki
2007-08-01 23:48 ` Andrew Morton
2007-08-02 11:15 ` Rafael J. Wysocki
2007-08-02 17:38 ` [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping (updated) Rafael J. Wysocki
2007-08-02 18:40 ` Oleg Nesterov
2007-08-02 21:13 ` Rafael J. Wysocki
2007-08-02 21:23 ` Oleg Nesterov [this message]
2007-08-02 21:49 ` Rafael J. Wysocki
2007-08-02 22:05 ` Oleg Nesterov
2007-08-01 21:36 ` [PATCH -mm 3/3] Freezer: Measure freezing time Rafael J. Wysocki
2007-08-01 23:53 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070802212307.GA521@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®