From: Oleg Nesterov <oleg@tv-sign.ru>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kill an obsolete sub-thread-ptrace stuff
Date: Sat, 4 Aug 2007 02:00:48 +0400 [thread overview]
Message-ID: <20070803220048.GA277@tv-sign.ru> (raw)
In-Reply-To: <20070803215101.481DD4D04BC@magilla.localdomain>
On 08/03, Roland McGrath wrote:
>
> > There is a couple of subtle checks which were needed to handle ptracing from
> > the same thread group. This was deprecated a long ago, imho this code just
> > complicates the understanding.
>
> Looks ok to me.
Thanks!
> > And, the "->parent->signal->flags & SIGNAL_GROUP_EXIT" check in exit_notify()
> > is not right. SIGNAL_GROUP_EXIT can mean exec(), not exit_group(). This means
> > ptracer can lose a ptraced zombie on exec(). Minor problem, but still the bug.
>
> This bug never happens because this check is only in the now-impossible
> ptrace-same-group case.
This means that changelog is wrong and should be changed.
However, I disagree. exit_notify() doesn't check the ptrace-same-group case. So,
unless I missed something, we set EXIT_DEAD in any case, even if ptracer doesn't
belong to our thread group.
No?
Oleg.
next prev parent reply other threads:[~2007-08-03 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 21:04 Oleg Nesterov
2007-08-03 21:51 ` Roland McGrath
2007-08-03 22:00 ` Oleg Nesterov [this message]
2007-08-03 22:06 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070803220048.GA277@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®