From: Oleg Nesterov <oleg@tv-sign.ru>
To: Gregory Haskins <ghaskins@novell.com>
Cc: Daniel Walker <dwalker@mvista.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure
Date: Mon, 6 Aug 2007 23:33:14 +0400 [thread overview]
Message-ID: <20070806193314.GB101@tv-sign.ru> (raw)
In-Reply-To: <20070802195049.GA361@tv-sign.ru>
Gregory, we seem to more or less agree with each other, but still...
On 08/02, Oleg Nesterov wrote:
>
> On 08/01, Gregory Haskins wrote:
> >
> > On Thu, 2007-08-02 at 02:22 +0400, Oleg Nesterov wrote:
> >
> > > No,
> >
> > You sure are a confident one ;)
>
> Yeah, this is a rare case when I am very sure I am right ;)
>
> I strongly believe you guys take a _completely_ wrong approach.
> queue_work() should _not_ take the priority of the caller into
> account, this is bogus.
OK. I have to take my words back. I completely misunderstood why you
are doing this and which problems you are trying to solve, my bad.
Perhaps, I am also wrong on the "work_struct's could be re-ordered"
issue. Yes, we can break the code which is currently correct, that
was my point. But I must admit, I can't imagine the "good" code mich
may suffer. Perhaps we can just document the change in behaviour, and
"deprecate" such a code.
The only objection (and you seem to agree) is that the "regular"
queue_work() should not always take the callers's priority as the
priority of work_struct.
Oleg.
next prev parent reply other threads:[~2007-08-06 21:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 0:26 Gregory Haskins
2007-08-01 3:52 ` Daniel Walker
2007-08-01 11:59 ` Gregory Haskins
2007-08-01 15:10 ` Daniel Walker
2007-08-01 15:19 ` Gregory Haskins
2007-08-01 15:55 ` Daniel Walker
2007-08-01 17:32 ` Gregory Haskins
2007-08-01 21:48 ` Esben Nielsen
2007-08-01 17:01 ` Peter Zijlstra
2007-08-01 17:10 ` Daniel Walker
2007-08-01 18:26 ` Oleg Nesterov
2007-08-01 18:39 ` Daniel Walker
2007-08-01 20:25 ` Oleg Nesterov
2007-08-01 18:12 ` Oleg Nesterov
2007-08-01 18:29 ` Daniel Walker
2007-08-01 20:18 ` Oleg Nesterov
2007-08-01 20:32 ` Oleg Nesterov
2007-08-01 20:43 ` Daniel Walker
2007-08-01 20:34 ` Daniel Walker
2007-08-01 20:50 ` Oleg Nesterov
2007-08-01 21:02 ` Daniel Walker
2007-08-01 21:13 ` Gregory Haskins
2007-08-01 21:34 ` Oleg Nesterov
2007-08-01 21:59 ` Gregory Haskins
2007-08-01 22:22 ` Oleg Nesterov
2007-08-01 23:53 ` Gregory Haskins
2007-08-02 19:50 ` Oleg Nesterov
2007-08-06 11:35 ` Gregory Haskins
2007-08-06 14:26 ` Oleg Nesterov
2007-08-06 14:57 ` Gregory Haskins
2007-08-06 15:36 ` Oleg Nesterov
2007-08-06 15:50 ` Gregory Haskins
2007-08-06 16:50 ` Oleg Nesterov
2007-08-06 16:57 ` Gregory Haskins
2007-08-06 11:49 ` Ingo Molnar
2007-08-06 13:18 ` Oleg Nesterov
2007-08-06 13:29 ` Peter Zijlstra
2007-08-06 13:32 ` Peter Zijlstra
2007-08-06 14:45 ` Oleg Nesterov
2007-08-06 14:52 ` Peter Zijlstra
2007-08-06 16:40 ` Oleg Nesterov
2007-08-06 15:04 ` Gregory Haskins
2007-08-06 15:38 ` Oleg Nesterov
2007-08-06 19:33 ` Oleg Nesterov [this message]
2007-08-06 19:37 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070806193314.GB101@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=dwalker@mvista.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®