mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: suspend-devel@lists.sourceforge.net
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Antonino A. Daplas" <adaplas@gmail.com>,
	Jeff Chua <jeff.chua.linux@gmail.com>,
	lkml <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [Suspend-devel] Linux 2.6.23-rc2
Date: Mon, 6 Aug 2007 21:17:49 +0200	[thread overview]
Message-ID: <200708062117.50023.rjw@sisk.pl> (raw)
In-Reply-To: <46B74F08.1050909@zytor.com>

On Monday, 6 August 2007 18:40, H. Peter Anvin wrote:
> Rafael J. Wysocki wrote:
> > On Monday, 6 August 2007 02:36, Jeff Chua wrote:
> >> On 8/6/07, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >>
> >>> What does 's2ram -i' say about your machine?
> >> This machine can be identified by:
> >>     sys_vendor   = "LENOVO"
> >>     sys_product  = "1702E7A"
> >>     sys_version  = "ThinkPad X60s"
> >>     bios_version = "7BETD0WW (2.11 )"
> > 
> > This means it's not in the whitelist, AFAICS.
> > 
> > Similar machines are known to work with "--acpi_sleep=3" or with
> > "--acpi_sleep=1 --vbe_mode".
> > 
> 
> I'm not all that familiar with s2ram.

It's just a wrapper around the kernel's suspend code that allows you to restore
the state of the graphics by running some additional code in real mode from
the user space.

> Any feel for why the behaviour would have changed from the old setup code at
> all?

With "--vbe_mode" s2ram saves the VBE mode setting before the suspend and sets
it to the same value after the resume.  Thus, it seems that the VBE mode
setting was previously preserved across the suspend/resume cycle and now it is
not.

Running s2ram with "--acpi_sleep 1" is equivalent to echoing 1 to
/proc/sys/kernel/acpi_video_flags before the suspend.

> Since the setup code isn't entered on resume from STR (unlike resume from
> STD), as far as I know, there can only be "some little bit of state" hanging
> around. 

The real mode code executed during resume is in
arch/x86_64/kernel/acpi/wakeup.S or in arch/i386/kernel/acpi/wakeup.S ,
depending on the architecture.

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth

  reply	other threads:[~2007-08-06 19:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-05 12:11 Jeff Chua
2007-08-05 12:40 ` Antonino A. Daplas
2007-08-05 13:26   ` Jeff Chua
2007-08-05 16:47     ` Rafael J. Wysocki
2007-08-06  0:36       ` Jeff Chua
2007-08-06 11:26         ` Rafael J. Wysocki
2007-08-06 12:34           ` Jeff Chua
2007-08-06 16:40           ` H. Peter Anvin
2007-08-06 19:17             ` Rafael J. Wysocki [this message]
2007-08-06 15:40     ` Jan Engelhardt
2007-08-06 16:06       ` Jeff Chua
2007-08-06 16:34         ` Jan Engelhardt
2007-08-06 16:46         ` Indan Zupancic
2007-08-06 17:16           ` H. Peter Anvin
2007-08-06 17:32             ` Indan Zupancic
2007-08-06 17:33               ` H. Peter Anvin
2007-08-06 22:53                 ` Jeff Chua
2007-08-06 22:54                   ` H. Peter Anvin
2007-08-06 22:57                     ` Jeff Chua
2007-08-06 23:00                       ` H. Peter Anvin
2007-08-06 22:48           ` Jeff Chua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708062117.50023.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=adaplas@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=suspend-devel@lists.sourceforge.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®