From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935612AbXHGXzx (ORCPT ); Tue, 7 Aug 2007 19:55:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755884AbXHGXzl (ORCPT ); Tue, 7 Aug 2007 19:55:41 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:52376 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934337AbXHGXzV (ORCPT ); Tue, 7 Aug 2007 19:55:21 -0400 X-Sasl-enc: kXYi1OC4TeBHC2oVryxqWELD0237Sc+I9whwyYAalJBb 1186530919 Date: Tue, 7 Aug 2007 20:55:16 -0300 From: Henrique de Moraes Holschuh To: Pavel Machek Cc: ibm-acpi-devel@lists.sourceforge.net, kernel list Subject: Re: refcounting problems with ibm_acpi but acpi=off Message-ID: <20070807235516.GD2139@khazad-dum.debian.net> References: <20070807104500.GA1684@elf.ucw.cz> <20070807142607.GA7414@khazad-dum.debian.net> <20070807214058.GA4413@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070807214058.GA4413@elf.ucw.cz> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Aug 2007, Pavel Machek wrote: > > > --- a/drivers/acpi/ibm_acpi.c > > > +++ b/drivers/acpi/ibm_acpi.c > > > @@ -2695,6 +2695,9 @@ static void acpi_ibm_exit(void) > > > { > > > int i; > > > > > > + if (acpi_disabled) > > > + return; > > > + > > > for (i = ARRAY_SIZE(ibms) - 1; i >= 0; i--) > > > ibm_exit(&ibms[i]); > > > > > > > > > > Indeed it is required, my bad. > > > > Acked-by: Henrique de Moraes Holschuh > > > > Do you want me to forward a git patch to Len brown? > > Yes, please. Hmm, seems like at least asus_acpi is affected by same problem. I just tested it, and thinkpad-acpi with all accepted patches by Len is not affected by this problem, only some versions of ibm-acpi is. So there's nothing to send to Len. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh