From: Olaf Hering <olaf@aepfle.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] remove binfmts.h from header exports
Date: Wed, 8 Aug 2007 19:28:21 +0200 [thread overview]
Message-ID: <20070808172821.GA3654@aepfle.de> (raw)
In-Reply-To: <b6fcc0a0708080012w1794ad84ma2a3b5a84eb5b8b@mail.gmail.com>
On Wed, Aug 08, Alexey Dobriyan wrote:
> > > And? Does it contain stuff which is userspace visible?
> > > binfmts.h has at least CORENAME_MAX_SIZE and SUID_DUMP_*
> >
> > Yes, its inside __KERNEL__.
>
> Can't you accept for a second that some stuff under __KERNEL__
> was put there by mistake?
I wonder why the defines exist at all? My grep doesnt find SUID_DUMP_*.
Looking at the commit message from d6e711448137ca3301512cec41a2c2ce852b3d0a
...
> > if (current->euid == current->uid && current->egid == current->gid)
> > current->mm->dumpable = 1;
>
> Should this be SUID_DUMP_USER?
Actually the feedback I had from last time was that the SUID_ defines
should go because its clearer to follow the numbers. They can go
everywhere (and there are lots of places where dumpable is tested/used
as a bool in untouched code)
...
Exporting a random array size is not very useful. The app and the kernel
has to check the string length anyway.
So lets remove the header and the 3 unused defines.
next prev parent reply other threads:[~2007-08-08 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 20:16 Olaf Hering
2007-08-07 20:37 ` Alexey Dobriyan
2007-08-08 6:14 ` Olaf Hering
2007-08-08 7:12 ` Alexey Dobriyan
2007-08-08 17:28 ` Olaf Hering [this message]
2007-08-07 23:35 ` Rene Herman
2007-08-08 6:10 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808172821.GA3654@aepfle.de \
--to=olaf@aepfle.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome