From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>, lguest <lguest@ozlabs.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Glauber de Oliveira Costa <glommer@gmail.com>,
Jes Sorensen <jes@sgi.com>, Carsten Otte <cotte@de.ibm.com>,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory
Date: Thu, 9 Aug 2007 15:31:33 +1000 [thread overview]
Message-ID: <20070809153133.d5dff7b6.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20070809044125.459178259@goodmis.org>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi Steven,
I am just being pedantic here (and I should have beaten up on Rusty
before now ... :-)
On Thu, 09 Aug 2007 00:36:30 -0400 Steven Rostedt <rostedt@goodmis.org>
wrote:
>
> --- a/include/asm-i386/lg.h
> +++ b/include/asm-i386/lg.h
> @@ -1,5 +1,5 @@
> -#ifndef _LGUEST_H
> -#define _LGUEST_H
> +#ifndef _I386_LGUEST_H
> +#define _I386_LGUEST_H
Maybe _ASM_LG_H or _I386_LG_H ? And there is a comment on the #endif at
the end of the file that should match.
> +++ b/include/linux/lg.h
> @@ -0,0 +1,30 @@
> +#ifndef _LINUX_LGUEST_H
> +#define _LINUX_LGUEST_H
Maybe _LINUX_LG_H ?
Also (this is for Rusty) include/linux/lguest.h is protected by
_ASM_LGUEST_H ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-08-09 5:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 4:36 [PATCH 0/5 -v2] Modify lguest32 to make room for lguest64 (version 2) Steven Rostedt
2007-08-09 4:36 ` [PATCH 1/5 -v2] move lg.h to include/asm-<arch> Steven Rostedt
2007-08-09 4:36 ` [PATCH 2/5 -v2] Change lguest launcher to use asm generic include Steven Rostedt
2007-08-09 4:36 ` [PATCH 3/5 -v2] Remove __pa() use in hvc_lguest Steven Rostedt
2007-08-09 4:36 ` [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory Steven Rostedt
2007-08-09 5:31 ` Stephen Rothwell [this message]
2007-08-09 12:19 ` Steven Rostedt
2007-08-09 4:36 ` [PATCH 5/5 -v2] Move the lguest files that are i386 specific Steven Rostedt
2007-08-09 5:42 ` Stephen Rothwell
2007-08-09 12:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809153133.d5dff7b6.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=cotte@de.ibm.com \
--cc=glommer@gmail.com \
--cc=jes@sgi.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®