mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MTD] Fix CFI build error with meaningless nonfunctional .config
Date: Fri, 10 Aug 2007 09:41:40 +0200	[thread overview]
Message-ID: <20070810074140.GB28264@elte.hu> (raw)
In-Reply-To: <1186717841.7282.104.camel@shinybook.infradead.org>


* David Woodhouse <dwmw2@infradead.org> wrote:

> On Mon, 2007-08-06 at 18:15 +0200, Ingo Molnar wrote:
> > randconfig testing on .23-rc2 triggered the following build error:
> 
> When building NOR flash support, you have compile-time options for the 
> bus width and the number of individual chips which are interleaved 
> together onto that bus. The code to deal with arbitrary geometry is a 
> bit convoluted, and people want to just configure it for the specific 
> hardware they have, to avoid the runtime overhead.
> 
> Selecting _none_ of the available options doesn't make any sense. You 
> should have at least one. This makes it build though, since people 
> persist in trying.

i didnt persist - randconfig picked it - it's a legit .config.

> +#ifndef cfi_interleave
> +#warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
> +static inline int cfi_interleave(void *cfi)
> +{
> +	BUG();
> +	return 0;

looks quite quirky. Is there no Kconfig-space solution for this?

	Ingo

  reply	other threads:[~2007-08-10  7:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-06 16:15 [build error] error: implicit declaration of function 'cfi_interleave' Ingo Molnar
2007-08-10  3:50 ` [PATCH] [MTD] Fix CFI build error with meaningless nonfunctional .config David Woodhouse
2007-08-10  7:41   ` Ingo Molnar [this message]
2007-08-10  7:45     ` David Woodhouse
2007-08-12 16:24       ` Ingo Molnar
2007-08-12 17:29         ` Josh Boyer
2007-08-13  0:00         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070810074140.GB28264@elte.hu \
    --to=mingo@elte.hu \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®