Re: [PATCH 1/2] oprofile: Make callgraph use dump_trace() on i386/x86_64

[Jan Blunck <jblunck@suse.de>]

On Fri, Aug 10, Andi Kleen wrote:

> On Friday 10 August 2007 15:35:29 jblunck@suse.de wrote:
> > This patch improves oprofile callgraphs for i386/x86_64. The old backtracing
> > code was unable to produce even kernel backtraces if the kernel wasn't
> > compiled with framepointers. The code now uses dump_trace().
> 
> Hmm one issue i didn't notice before: with imprecise backtrace
> the profiling could be a little random because even if the same
> call chain is hit repeatedly the garbage left over stack entries also
> reported could vary and then cause oprofile to put it into different
> buckets. But there is probably not much that can be 
> done about that.

Yes, but before we didn't had any callgraphs for x86_64 since with
framepointers enabled the backtrace is having very strange results too.

I guess this is the best what we can achieve at the moment. Eventually when we
have fast, precise backtraces in the kernel the oprofile code benefits from
that automatically with this patch.