From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Stable Team <stable@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jean-Baptiste Vignaud <vignaud@xandmail.fr>,
"marcin.slusarz" <marcin.slusarz@gmail.com>,
Jarek Poplawski <jarkao2@o2.pl>
Subject: [patch 1/3] genirq: cleanup mismerge artifact
Date: Sun, 12 Aug 2007 15:46:34 -0000 [thread overview]
Message-ID: <20070812152303.083017058@inhelltoy.tec.linutronix.de> (raw)
In-Reply-To: <20070812152213.551812576@inhelltoy.tec.linutronix.de>
[-- Attachment #1: genirq-do-not-resend-level-irqs.patch --]
[-- Type: text/plain, Size: 1105 bytes --]
commit 5a43a066b11ac2fe84cf67307f20b83bea390f83
genirq: Allow fasteoi handler to retrigger disabled interrupts
was erroneously applied to handle_level_irq(). This adds the irq
retrigger / resend functionality to the level irq handler.
Revert the offending bits.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/chip.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Index: linux-2.6/kernel/irq/chip.c
===================================================================
--- linux-2.6.orig/kernel/irq/chip.c 2007-08-12 17:18:04.000000000 +0200
+++ linux-2.6/kernel/irq/chip.c 2007-08-12 17:18:04.000000000 +0200
@@ -352,13 +352,10 @@ handle_level_irq(unsigned int irq, struc
* keep it masked and get out of here
*/
action = desc->action;
- if (unlikely(!action || (desc->status & IRQ_DISABLED))) {
- desc->status |= IRQ_PENDING;
+ if (unlikely(!action || (desc->status & IRQ_DISABLED)))
goto out_unlock;
- }
desc->status |= IRQ_INPROGRESS;
- desc->status &= ~IRQ_PENDING;
spin_unlock(&desc->lock);
action_ret = handle_IRQ_event(irq, action);
--
next prev parent reply other threads:[~2007-08-12 15:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 15:46 [patch 0/3] [patch 0/3] genirq: Suppress resend of level interrupts Thomas Gleixner
2007-08-12 15:46 ` Thomas Gleixner [this message]
2007-08-12 15:46 ` [patch 2/3] genirq: suppress " Thomas Gleixner
2007-08-12 15:46 ` [patch 3/3] genirq: mark io_apic level interrupts to avoid resend Thomas Gleixner
2007-08-13 11:28 ` Jarek Poplawski
2007-08-13 12:07 ` Thomas Gleixner
2007-08-13 13:53 ` Jarek Poplawski
2007-08-13 14:16 ` Jarek Poplawski
2007-08-13 16:30 ` Thomas Gleixner
2007-08-14 7:12 ` Jarek Poplawski
2007-08-14 8:10 ` Thomas Gleixner
2007-08-14 9:23 ` Jarek Poplawski
2007-08-13 19:07 ` Benjamin Herrenschmidt
2007-08-14 8:01 ` Jarek Poplawski
2007-08-13 18:42 ` Benjamin Herrenschmidt
2007-08-14 7:08 ` [patch 0/3] [patch 0/3] genirq: Suppress resend of level interrupts Marcin Ślusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070812152303.083017058@inhelltoy.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vignaud@xandmail.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®