From: Jan Blunck <jblunck@suse.de>
To: dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 05/11] dm-snap: remove SECTOR_SHIFT define
Date: Mon, 13 Aug 2007 11:20:36 +0200 [thread overview]
Message-ID: <20070813092036.GB12730@hasse.suse.de> (raw)
In-Reply-To: <20070810203854.GG2064@agk.fab.redhat.com>
On Fri, Aug 10, Alasdair G Kergon wrote:
> On Fri, Aug 10, 2007 at 10:02:09PM +0200, Jan Blunck wrote:
> > Sector size on Linux is always 512 bytes. Don't even try to give the
> > impression this is changeable.
>
> If that's what worries you, add a comment next to the definition,
> perhaps?
That and that the code just looks more like the rest of the block layer
code. Only a few users (UFS, MSDOS, HFS, IDE) use a predefined
SECTOR_{SHIFT,SIZE}.
> It's there so you can easily locate all the places within dm that
> perform these conversions by using a simple search. Searching for '9'
> wouldn't be as easy. (I don't know about other people, but I find the
> code easier to read the way it is.)
Hmm, so I guess this is more about dis/like of how the code looks. Maybe we
should define a global SECTOR_{SIZE,SHIFT} into blkdev.h.
Regards,
Jan
--
Jan Blunck <jblunck@suse.de>
next prev parent reply other threads:[~2007-08-13 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070810200204.455820246@suse.de>
[not found] ` <20070810200205.703776854@suse.de>
2007-08-10 20:38 ` Alasdair G Kergon
2007-08-13 9:20 ` Jan Blunck [this message]
[not found] ` <20070810200205.299669010@suse.de>
2007-08-10 20:43 ` [patch 03/11] dm-snap: Remove dead queued_bios code Alasdair G Kergon
2007-08-13 9:29 ` Jan Blunck
[not found] ` <25205.2138712772$1186776751@news.gmane.org>
2007-08-12 17:20 ` [patch 01/11] dm-snap: Replace special round_down() Jan Blunck
[not found] ` <20070810200204.896267894@suse.de>
2007-08-13 9:35 ` [dm-devel] " Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070813092036.GB12730@hasse.suse.de \
--to=jblunck@suse.de \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®