From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: WU Fengguang <wfg@mail.ustc.edu.cn>,
linux-kernel <linux-kernel@vger.kernel.org>,
James Morris <jmorris@redhat.com>
Subject: Re: [PATCH] fix NULL pointer dereference in __vm_enough_memory()
Date: Mon, 13 Aug 2007 22:01:42 -0700 [thread overview]
Message-ID: <20070813220142.99e46091.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070813140106.23b93ff5@the-village.bc.nu>
On Mon, 13 Aug 2007 14:01:06 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Mon, 13 Aug 2007 15:38:53 +0800
> WU Fengguang <wfg@mail.ustc.edu.cn> wrote:
>
> > On Sun, Aug 12, 2007 at 04:17:44PM +0100, Alan Cox wrote:
> > > Try this (it compiles but isnt tested). Its a weekend here, the sun is
> > > shining, the beach is a short walk, and I have more interesting things to
> > > do right now 8)
> >
> > Have a nice day~~~ It works!
>
> Ok please apply the patch then Andrew
>
> ---
>
> The new exec code inserts an accounted vma into an mm struct which is not
> current->mm. The existing memory check code has a hard coded assumption
> that this does not happen as does the security code.
>
> As the correct mm is known we pass the mm to the security method and the
> helper function. A new security test is added for the case where we need
> to pass the mm and the existing one is modified to pass current->mm to
> avoid the need to change large amounts of code.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/include/linux/mm.h linux-2.6.23rc1-mm1/include/linux/mm.h
> --- linux.vanilla-2.6.23rc1-mm1/include/linux/mm.h 2007-07-26 15:02:58.000000000 +0100
erp, we have major version skew between 2.6.23-rc1-mm1 and 2.6.23-rc3 here, sorry.
Could I ask for a redone patch against mainline?
Thanks.
next prev parent reply other threads:[~2007-08-14 5:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46BEF5C0.3080902@linux.vnet.ibm.com>
[not found] ` <20070812120902.GA9972@mail.ustc.edu.cn>
[not found] ` <20070812122746.GA10109@mail.ustc.edu.cn>
2007-08-12 12:27 ` [BUGFIX] " WU Fengguang
2007-08-12 13:19 ` Alan Cox
[not found] ` <20070812140917.GA13683@mail.ustc.edu.cn>
2007-08-12 14:09 ` WU Fengguang
2007-08-12 15:17 ` Alan Cox
2007-08-12 16:21 ` Cyrill Gorcunov
[not found] ` <20070813002342.GA6908@mail.ustc.edu.cn>
2007-08-13 0:23 ` WU Fengguang
2007-08-13 9:53 ` Cyrill Gorcunov
2007-08-13 11:22 ` Alan Cox
2007-08-13 11:55 ` Cyrill Gorcunov
2007-08-13 0:14 ` Rene Herman
[not found] ` <20070813073853.GA5262@mail.ustc.edu.cn>
2007-08-13 7:38 ` WU Fengguang
2007-08-13 13:01 ` [PATCH] fix " Alan Cox
2007-08-14 5:01 ` Andrew Morton [this message]
2007-08-14 17:50 ` Tobias Diedrich
2007-08-14 17:10 ` [BUGFIX] " Andy Isaacson
[not found] ` <20070815085308.GA18959@mail.ustc.edu.cn>
2007-08-15 8:53 ` WU Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070813220142.99e46091.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome