From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933798AbXHNSdo (ORCPT ); Tue, 14 Aug 2007 14:33:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760568AbXHNSdb (ORCPT ); Tue, 14 Aug 2007 14:33:31 -0400 Received: from smtp-out001.kontent.com ([81.88.40.215]:41894 "EHLO smtp-out.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757211AbXHNSda (ORCPT ); Tue, 14 Aug 2007 14:33:30 -0400 From: Oliver Neukum To: Paolo Ornati Subject: Re: [linux-usb-devel] spontaneous disconnect with "usb-storage: implement autosuspend" Date: Tue, 14 Aug 2007 20:33:22 +0200 User-Agent: KMail/1.9.7 Cc: linux-usb-devel@lists.sourceforge.net, Alan Stern , Linux Kernel Mailing List References: <20070814131557.5653d991@localhost> <200708141746.16958.oliver@neukum.org> <20070814183857.28997de1@localhost> In-Reply-To: <20070814183857.28997de1@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708142033.23158.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag 14 August 2007 schrieb Paolo Ornati: > On Tue, 14 Aug 2007 17:46:16 +0200 > Oliver Neukum wrote: > > > Am Dienstag 14 August 2007 schrieb Paolo Ornati: > > > Hewlett-Packard PhotoSmart 720 / PhotoSmart 935 (storage) > > > > Please try this patch. > > Tried on -rc3 but it doesn't work, dmesg attached. > > However I've found that if "hald" is running the problems doesn't > happen (I think it's just hidden by the fact that hald do some polling > on it preventing autosuspend to trigger). Exactly. This is not reliable. It needs to be done in kernel. This patch should do it. Regards Oliver --- --- a/drivers/usb/core/quirks.c 2007-08-14 17:42:22.000000000 +0200 +++ b/drivers/usb/core/quirks.c 2007-08-14 20:30:28.000000000 +0200 @@ -30,6 +30,8 @@ static const struct usb_device_id usb_quirk_list[] = { /* HP 5300/5370C scanner */ { USB_DEVICE(0x03f0, 0x0701), .driver_info = USB_QUIRK_STRING_FETCH_255 }, + /* Hewlett-Packard PhotoSmart 720 / PhotoSmart 935 (storage) */ + { USB_DEVICE(0x03f0, 0x4002), .driver_info = USB_QUIRK_NO_AUTOSUSPEND }, /* Acer Peripherals Inc. (now BenQ Corp.) Prisa 640BU */ { USB_DEVICE(0x04a5, 0x207e), .driver_info = USB_QUIRK_NO_AUTOSUSPEND }, /* Benq S2W 3300U */