mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Sebastian Siewior <sebastian@breakpoint.cc>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: Re: [patch 1/2] i386: use asm() like the other atomic operations already do.
Date: Wed, 15 Aug 2007 02:20:35 +0200	[thread overview]
Message-ID: <20070815002034.GW3406@bingen.suse.de> (raw)
In-Reply-To: <20070814224337.547449183@breakpoint.cc>

> My config with march=pentium-m and gcc (GCC) 4.1.2 (Gentoo 4.1.2):
>   text    data     bss     dec     hex filename
> 3434150  249176  176128 3859454  3ae3fe atomic_normal/vmlinux
> 3435308  249176  176128 3860612  3ae884 atomic_inlineasm/vmlinux

What is the difference between atomic_normal and atomic_inlineasm? 

>  /**
>   * atomic_read - read atomic variable
>   * @v: pointer of type atomic_t
> - * 
> + *

Please don't change white space in patches

>   * Atomically reads the value of @v.
> - */ 
> -#define atomic_read(v)		((v)->counter)
> + */
> +static __inline__ int atomic_read(const atomic_t *v)
> +{
> +	int t;
> +
> +	__asm__ __volatile__(

And don't use __*__ in new code

-Andi

  reply	other threads:[~2007-08-14 23:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14 22:38 [patch 0/2] use asm() for atomic_{read|set} Sebastian Siewior
2007-08-14 22:38 ` [patch 1/2] i386: use asm() like the other atomic operations already do Sebastian Siewior
2007-08-15  0:20   ` Andi Kleen [this message]
2007-08-15  7:04     ` Sebastian Siewior
2007-08-15  8:40     ` Herbert Xu
2007-08-15 13:02       ` Satyam Sharma
2007-08-15 13:45         ` Sebastian Siewior
2007-08-15 17:02       ` Chris Snook
2007-08-15 23:44         ` Herbert Xu
2007-08-16  1:37           ` Nick Piggin
2007-08-16 19:23           ` Chris Snook
2007-08-17  0:04             ` Herbert Xu
2007-08-14 22:38 ` [patch 2/2] x86_64: " Sebastian Siewior
2007-08-15 20:54 [patch 0/2] use asm() for atomic_{read|set} (shot 2) Sebastian Siewior
2007-08-15 20:54 ` [patch 1/2] i386: use asm() like the other atomic operations already do Sebastian Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070815002034.GW3406@bingen.suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome