From: Jan Kara <jack@suse.cz>
To: Josef Bacik <jbacik@redhat.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix panic in jbd by adding locks
Date: Wed, 15 Aug 2007 13:37:37 +0200 [thread overview]
Message-ID: <20070815113737.GC7642@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20070814152255.GB24127@dhcp-243-37.rdu.redhat.com>
Hello,
> It is possible to panic the box by a race condition that exists in the
> journalling code where we do not take the j_revoke_lock when traversing the
> journal's revoked record list. This patch has been tested and we haven't seen
> the issue yet, its a rather straightforward and correct (at least I think so :)
> fix. Thank you,
In principle, the patch looks fine. The only thing I'm wondering about
is how that panic can happen... Journal write_revoke_records() is called
from journal_commit_transaction() when revoke table for the committing
transaction shouldn't see any further changes. So maybe the patch is
masking a different problem.
Do you have a way of reproducing the problem? Any stack trace
available?
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
next prev parent reply other threads:[~2007-08-15 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 15:22 Josef Bacik
2007-08-15 11:37 ` Jan Kara [this message]
2007-08-15 12:17 ` Josef Bacik
2007-08-16 16:08 ` Jan Kara
2007-08-16 16:37 ` Josef Bacik
2007-08-20 15:20 ` Jan Kara
2007-08-21 15:43 ` Josef Bacik
2007-08-21 16:48 ` Jan Kara
2007-08-21 17:45 ` Josef Bacik
2007-08-23 18:41 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070815113737.GC7642@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=jbacik@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®