Re: [PATCH 3/3] ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help

["Michael S. Tsirkin" <mst@dev.mellanox.co.il>]

> Quoting Henrique de Moraes Holschuh <hmh@hmh.eng.br>:
> Subject: Re: [PATCH 3/3] ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help
> 
> On Thu, 16 Aug 2007, Michael S. Tsirkin wrote:
> > > I *can* make the compile-time option a module parameter, though.  That
> > > wouldn't be much of a problem, and the compile-time option would select the
> > > default for that parameter, but it would be easier to override it at run
> > > time (you can already do it, but it requires reprogramming various driver
> > > parameters using sysfs and the input device IOCTLs).
> > > 
> > > Would a module parameter address enough of your concerns?  Kconfig would
> > > only set the default for that parameter, then...
> > 
> > I really think modifying defaults it not a great idea.
> > What about adding a writeable module parameter?
> > Then new HAL would just write to /sysfs/module/thinkpad/parameters/interface_version to 
> > switch to new behaviour.
> 
> Nah. This thing regulates what the module has to do when it loads and inits
> the firmware,

This does not have to be at module load time, though, does it?

> and the whole point of the new behaviour is to get userspace
> to be as hands' off as possible, so that we can auto-tune things better
> in-kernel, without a need to worry about HAL and friends overwriting local
> admin configurations needlessly.
> 
> I will probably have to do something like the strict versioned interfaces of
> wireless extensions, I think. It really is a case of a deprecation of
> current userland interfaces done sanely.  Right now I am thinking about
> giving userland two kernel releases before I change the default interface
> level, and one to two years to remove the older ones.

-- 
MST