From: Jesper Juhl <jesper.juhl@gmail.com>
To: Marcio Saito <marcio@cyclades.com>
Cc: Randolph Bentson <bentson@grieg.seaslug.org>,
Jiri Slaby <jirislaby@gmail.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Jesper Juhl <jesper.juhl@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Cyclades: Avoid label defined but not used warning
Date: Fri, 17 Aug 2007 23:05:23 +0200 [thread overview]
Message-ID: <200708172305.23730.jesper.juhl@gmail.com> (raw)
Hi,
I don't like compiler warnings, especially not when they are easy to
avoid.
Building cyclades driver without CONFIG_PCI currently results in this :
CC drivers/char/cyclades.o
drivers/char/cyclades.c: In function 'cy_init':
drivers/char/cyclades.c:5488: warning: label 'err_unr' defined but not used
That's easily avoided, with no ill effects by simply moving what's
under the 'err_unr' label (used from only a single location) inside
the existing #ifdef - so that's what this patch does.
Compile tested on i386 only. I don't have the hardware to do any
other testing.
Please consider applying.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
drivers/char/cyclades.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c
index 9e0adfe..858bdab 100644
--- a/drivers/char/cyclades.c
+++ b/drivers/char/cyclades.c
@@ -5480,13 +5480,13 @@ static int __init cy_init(void)
#ifdef CONFIG_PCI
/* look for pci boards */
retval = pci_register_driver(&cy_pci_driver);
- if (retval && !nboards)
- goto err_unr;
+ if (retval && !nboards) {
+ tty_unregister_driver(cy_serial_driver);
+ goto err_frtty;
+ }
#endif
return 0;
-err_unr:
- tty_unregister_driver(cy_serial_driver);
err_frtty:
put_tty_driver(cy_serial_driver);
err:
reply other threads:[~2007-08-17 21:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708172305.23730.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=bentson@grieg.seaslug.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcio@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome