From: David Miller <davem@davemloft.net>
To: clameter@sgi.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: SLUB bug on sparc64
Date: Mon, 20 Aug 2007 16:01:48 -0700 (PDT) [thread overview]
Message-ID: <20070820.160148.11597718.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0708201124140.25298@schroedinger.engr.sgi.com>
From: Christoph Lameter <clameter@sgi.com>
Date: Mon, 20 Aug 2007 11:34:52 -0700 (PDT)
> On Fri, 17 Aug 2007, David Miller wrote:
>
> > When I force SLUB debugging on sparc64, it barfs on early bootup while
> > making the sysfs nodes. Removing the BUG()'s on the sysfs error
> > returns, and adding some tracing I captured the log below.
> >
> > BTW, I would recommending removing the BUG() calls, they serve only to
> > force someone hitting them to edit them out and reboot which is
> > absolutely pointless :-) This code can also often run before the
> > console is first enabled, making analysis of the error return that
> > much harder if it BUG()'s instead of trying to continue.
>
> Not sure what BUG's you are talking about.
The two BUG_ON()'s on "err" as returned from sysfs_slab_alias()
and sysfs_slab_add().
> Does this patch fix it?
Yep, it does, thanks a lot!
prev parent reply other threads:[~2007-08-20 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-18 5:17 David Miller
2007-08-20 18:34 ` Christoph Lameter
2007-08-20 23:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070820.160148.11597718.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®