Re: [PATCH] AH4: Update IPv4 options handling to conform to RFC 4302.

[Herbert Xu <herbert@gondor.apana.org.au>]

On Tue, Aug 21, 2007 at 02:44:33PM +0000, Nick Bowler wrote:
> In testing our ESP/AH offload hardware, I discovered an issue with how AH
> handles mutable fields in IPv4.  RFC 4302 (AH) states the following on the
> subject:
> 
>         For IPv4, the entire option is viewed as a unit; so even
>         though the type and length fields within most options are immutable
>         in transit, if an option is classified as mutable, the entire option
>         is zeroed for ICV computation purposes.

Good catch! Very few people test IP options so this one slipped
through.  Fortunately by the same token we can change this
without anybody noticing.

This requirement isn't new with 4302, 2402 says exactly the
same thing.

Please resend your patch to davem@davemloft.net with a cc to
netdev@vger.kernel.org.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt