From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762439AbXHVJGl (ORCPT ); Wed, 22 Aug 2007 05:06:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758770AbXHVIxm (ORCPT ); Wed, 22 Aug 2007 04:53:42 -0400 Received: from 1wt.eu ([62.212.114.60]:2139 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758659AbXHVIxi (ORCPT ); Wed, 22 Aug 2007 04:53:38 -0400 From: Willy Tarreau Message-Id: <20070822084011.%N@1wt.eu> References: <20070822083844.%N@1wt.eu> User-Agent: quilt/0.46-1 Date: Wed, 22 Aug 2007 11:39:10 +0200 To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Mingming Cao , Yan Zheng , , Andrew Morton , Greg Kroah-Hartman , Willy Tarreau Subject: [2.6.20.17 review 26/58] "ext4_ext_put_in_cache" uses __u32 to receive physical block number Content-Disposition: inline; filename=0026-ext4_ext_put_in_cache-uses-__u32-to-receive-physic.patch Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Yan Zheng wrote: > I think I found a bug in ext4/extents.c, "ext4_ext_put_in_cache" uses > "__u32" to receive physical block number. "ext4_ext_put_in_cache" is > used in "ext4_ext_get_blocks", it sets ext4 inode's extent cache > according most recently tree lookup (higher 16 bits of saved physical > block number are always zero). when serving a mapping request, > "ext4_ext_get_blocks" first check whether the logical block is in > inode's extent cache. if the logical block is in the cache and the > cached region isn't a gap, "ext4_ext_get_blocks" gets physical block > number by using cached region's physical block number and offset in > the cached region. as described above, "ext4_ext_get_blocks" may > return wrong result when there are physical block numbers bigger than > 0xffffffff. > You are right. Thanks for reporting this! Signed-off-by: Mingming Cao Cc: Yan Zheng Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman Signed-off-by: Willy Tarreau --- fs/ext4/extents.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index dc2724f..14b0b49 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -1397,7 +1397,7 @@ int ext4_ext_walk_space(struct inode *inode, unsigned long block, static void ext4_ext_put_in_cache(struct inode *inode, __u32 block, - __u32 len, __u32 start, int type) + __u32 len, ext4_fsblk_t start, int type) { struct ext4_ext_cache *cex; BUG_ON(len == 0); -- 1.5.2.5 --