mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Shannon Nelson <shannon.nelson@intel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net
Subject: Re: [PATCH v2 -mm 3/7] I/OAT: code cleanup from checkpatch output
Date: Thu, 23 Aug 2007 22:38:33 -0700	[thread overview]
Message-ID: <20070823223833.65fba17e.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070824001506.16997.43452.stgit@localhost.localdomain>

On Thu, 23 Aug 2007 17:15:06 -0700 Shannon Nelson wrote:

> Take care of a bunch of little code nits in ioatdma files
> 
> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
> Acked-by: David S. Miller <davem@davemloft.net>
> ---
> 
>  drivers/dma/ioat_dma.c |  200 +++++++++++++++++++++++++++---------------------
>  1 files changed, 111 insertions(+), 89 deletions(-)
> 
> diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
> index 55227d4..9a4d154 100644
> --- a/drivers/dma/ioat_dma.c
> +++ b/drivers/dma/ioat_dma.c

> -	printk(KERN_INFO "Intel(R) I/OAT DMA Engine found, %d channels\n",
> -		device->common.chancnt);
> +	printk(KERN_INFO " "
> +		 "ioatdma: Intel(R) I/OAT DMA Engine found, %d channels\n",
> +		 device->common.chancnt);
>  
>  	err = ioat_self_test(device);
>  	if (err)

> @@ -764,7 +784,8 @@ err_set_dma_mask:
>  	pci_disable_device(pdev);
>  err_enable_device:
>  
> -	printk(KERN_ERR "Intel(R) I/OAT DMA Engine initialization failed\n");
> +	printk(KERN_INFO " "
> +		"ioatdma: Intel(R) I/OAT DMA Engine initialization failed\n");
>  
>  	return err;
>  }

What's with these (KERN_INFO " "
			"...more strings");
??

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2007-08-24  5:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-24  0:14 [PATCH v2 -mm 0/7] I/OAT: Add support for DCA - Direct Cache Access Shannon Nelson
2007-08-24  0:14 ` [PATCH v2 -mm 1/7] I/OAT: New device ids Shannon Nelson
2007-08-24  0:15 ` [PATCH v2 -mm 2/7] I/OAT: Rename the source file Shannon Nelson
2007-08-24  0:15 ` [PATCH v2 -mm 3/7] I/OAT: code cleanup from checkpatch output Shannon Nelson
2007-08-24  5:38   ` Randy Dunlap [this message]
2007-08-24 16:39     ` Nelson, Shannon
2007-08-24  0:15 ` [PATCH v2 -mm 4/7] I/OAT: Split PCI startup from DMA handling code Shannon Nelson
2007-08-24  6:08   ` Randy Dunlap
2007-08-24 16:47     ` Nelson, Shannon
2007-08-24  0:15 ` [PATCH v2 -mm 5/7] I/OAT: Add support for MSI and MSI-X Shannon Nelson
2007-08-24 17:48   ` Randy Dunlap
2007-08-24 18:18     ` Nelson, Shannon
2007-08-24  0:15 ` [PATCH v2 -mm 6/7] DCA: Add Direct Cache Access driver Shannon Nelson
2007-08-24  5:55   ` Randy Dunlap
2007-08-24 16:43     ` Nelson, Shannon
2007-08-24  0:15 ` [PATCH v2 -mm 7/7] I/OAT: Add DCA services Shannon Nelson
2007-08-24 19:12   ` Randy Dunlap
2007-08-24 21:50     ` Nelson, Shannon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070823223833.65fba17e.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®